From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbdFJUpJ (ORCPT ); Sat, 10 Jun 2017 16:45:09 -0400 Received: from mga06.intel.com ([134.134.136.31]:2857 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdFJUpH (ORCPT ); Sat, 10 Jun 2017 16:45:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,325,1493708400"; d="scan'208";a="112829284" Date: Sun, 11 Jun 2017 04:44:18 +0800 From: kbuild test robot To: John Garry Cc: kbuild-all@01.org, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, linuxarm@huawei.com, arnd@arndb.de, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, Xiang Chen , John Garry Subject: Re: [PATCH v5 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock Message-ID: <201706110427.UEjoe6NO%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497017796-105067-4-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiang, [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/John-Garry/hisi_sas-hip08-support/20170611-014437 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/scsi/hisi_sas/hisi_sas_main.c:1208:1-18: ERROR: nested lock+irqsave that reuses flags from line 1178. vim +1208 drivers/scsi/hisi_sas/hisi_sas_main.c bf95e9ccc Xiang Chen 2017-06-09 1172 if (rc) { bf95e9ccc Xiang Chen 2017-06-09 1173 spin_unlock_irqrestore(&hisi_hba->lock, flags); 441c27401 John Garry 2016-08-24 1174 goto err_out; bf95e9ccc Xiang Chen 2017-06-09 1175 } bf95e9ccc Xiang Chen 2017-06-09 1176 spin_unlock_irqrestore(&hisi_hba->lock, flags); bf95e9ccc Xiang Chen 2017-06-09 1177 bf95e9ccc Xiang Chen 2017-06-09 @1178 spin_lock_irqsave(&dq->lock, flags); bf95e9ccc Xiang Chen 2017-06-09 1179 rc = hisi_hba->hw->get_free_slot(hisi_hba, dq); 441c27401 John Garry 2016-08-24 1180 if (rc) 441c27401 John Garry 2016-08-24 1181 goto err_out_tag; 441c27401 John Garry 2016-08-24 1182 bf95e9ccc Xiang Chen 2017-06-09 1183 dlvry_queue = dq->id; bf95e9ccc Xiang Chen 2017-06-09 1184 dlvry_queue_slot = dq->wr_point; bf95e9ccc Xiang Chen 2017-06-09 1185 441c27401 John Garry 2016-08-24 1186 slot = &hisi_hba->slot_info[slot_idx]; 441c27401 John Garry 2016-08-24 1187 memset(slot, 0, sizeof(struct hisi_sas_slot)); 441c27401 John Garry 2016-08-24 1188 441c27401 John Garry 2016-08-24 1189 slot->idx = slot_idx; 441c27401 John Garry 2016-08-24 1190 slot->n_elem = n_elem; 441c27401 John Garry 2016-08-24 1191 slot->dlvry_queue = dlvry_queue; 441c27401 John Garry 2016-08-24 1192 slot->dlvry_queue_slot = dlvry_queue_slot; 441c27401 John Garry 2016-08-24 1193 cmd_hdr_base = hisi_hba->cmd_hdr[dlvry_queue]; 441c27401 John Garry 2016-08-24 1194 slot->cmd_hdr = &cmd_hdr_base[dlvry_queue_slot]; 441c27401 John Garry 2016-08-24 1195 slot->task = task; 441c27401 John Garry 2016-08-24 1196 slot->port = port; 441c27401 John Garry 2016-08-24 1197 task->lldd_task = slot; 441c27401 John Garry 2016-08-24 1198 441c27401 John Garry 2016-08-24 1199 memset(slot->cmd_hdr, 0, sizeof(struct hisi_sas_cmd_hdr)); 441c27401 John Garry 2016-08-24 1200 441c27401 John Garry 2016-08-24 1201 rc = hisi_sas_task_prep_abort(hisi_hba, slot, device_id, 441c27401 John Garry 2016-08-24 1202 abort_flag, task_tag); 441c27401 John Garry 2016-08-24 1203 if (rc) 441c27401 John Garry 2016-08-24 1204 goto err_out_tag; 441c27401 John Garry 2016-08-24 1205 405314df5 John Garry 2017-03-23 1206 405314df5 John Garry 2017-03-23 1207 list_add_tail(&slot->entry, &sas_dev->list); 54c9dd2d2 John Garry 2017-03-23 @1208 spin_lock_irqsave(&task->task_state_lock, flags); 441c27401 John Garry 2016-08-24 1209 task->task_state_flags |= SAS_TASK_AT_INITIATOR; 54c9dd2d2 John Garry 2017-03-23 1210 spin_unlock_irqrestore(&task->task_state_lock, flags); 441c27401 John Garry 2016-08-24 1211 :::::: The code at line 1208 was first introduced by commit :::::: 54c9dd2d26d0951891516a956893428feb9aea17 scsi: hisi_sas: fix some sas_task.task_state_lock locking :::::: TO: John Garry :::::: CC: Martin K. Petersen --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation