From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbdFKJXr (ORCPT ); Sun, 11 Jun 2017 05:23:47 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33246 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbdFKJXq (ORCPT ); Sun, 11 Jun 2017 05:23:46 -0400 Date: Sun, 11 Jun 2017 11:23:42 +0200 From: Ingo Molnar To: Nicolas Pitre Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner Subject: Re: [PATCH v2 0/8] scheduler tinification Message-ID: <20170611092342.7jngfh4alp4w22xs@gmail.com> References: <20170606232450.30278-1-nicolas.pitre@linaro.org> <20170607160010.e2gtddlllflvr6er@gmail.com> <20170608075936.426zbwb63drsemgh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nicolas Pitre wrote: > > But the kernel complexity you introduce with this series stays with us! It > > will be an additional cost added to many scheduler commits going forward. It's > > an added cost for all the other usecases. > > OK, let's talk about that a bit. How isn't sched/core.c with its 7387 > lines not overly complex already? How is my moving of rt related code to > rt.c and dl related code to dl.c not helping things? Isn't it easier to > understand the 3500 lines of code in futex.c when half of it i.e. the PI > specific code is split into a separate file? I ask you. > > If you want to pick only those patches for now then please be my guest. > At lease the first two patches of the series should be mergeable without > even a doubt. That's a strawman argument - I was reacting to the combined effect of your series: > > > 23 files changed, 3190 insertions(+), 2897 deletions(-) A subset of the patches might be fine and note that in fact I already picked a patch from your series that made sense, I committed this patch of yours three days ago: f5832c1998af: sched/core: Omit building stop_sched_class when !SMP I'll pick others as well as long as they don't complicate the code. Please send a revised series that only does unambiguous complexity reduction/cleanups. Thanks, Ingo