From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbdFLNgN (ORCPT ); Mon, 12 Jun 2017 09:36:13 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19293 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbdFLNgM (ORCPT ); Mon, 12 Jun 2017 09:36:12 -0400 Date: Mon, 12 Jun 2017 16:35:57 +0300 From: Dan Carpenter To: Aviya Erenfeld Cc: gregkh@linuxfoundation.org, goudapatilk@gmail.com, insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars Message-ID: <20170612133557.k6hrnw4yjl4yb4ab@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2017 at 04:16:18PM +0300, Aviya Erenfeld wrote: > From: Aviya Erenfeld No need for this, your email is set up correctly so it works fine as-is. > > Shorten lines over 80 chars > > Signed-off-by: Aviya Erenfeld > --- > drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++++++++++++++++++--------- > 1 file changed, 39 insertions(+), 19 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > index cd348ca..c924c9e 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > @@ -68,7 +68,8 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv) > struct sta_info *psta; > s32 i; > > - pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); > + pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * > + NUM_STA + 4); None of these are aligned correctly. Run checkpatch.pl --strict over your patch. It should be something like: pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4); Also the patch is corrupted and doesn't apply. Read Documentation/process/email-clients.rst regards, dan carpenter