mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Guy Briggs <rgb@redhat.com>
To: Derek Robson <robsonde@gmail.com>
Cc: paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] audit: style fix
Date: Mon, 12 Jun 2017 10:00:45 -0400	[thread overview]
Message-ID: <20170612140044.GD21241@madcap2.tricolour.ca> (raw)
In-Reply-To: <20170612023303.3700-1-robsonde@gmail.com>

On 2017-06-12 14:33, Derek Robson wrote:
> Fixed checkpatch.pl warnings of "function definition argument FOO
>  should also have an identifier name"
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>

Sounds reasonable.
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>

> ---
>  kernel/audit.h | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/kernel/audit.h b/kernel/audit.h
> index ddfce2ea4891..90b891eea204 100644
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -247,13 +247,13 @@ struct audit_netlink_list {
>  	struct sk_buff_head q;
>  };
>  
> -int audit_send_list(void *);
> +int audit_send_list(void *_dest);
>  
>  extern int selinux_audit_rule_update(void);
>  
>  extern struct mutex audit_filter_mutex;
> -extern int audit_del_rule(struct audit_entry *);
> -extern void audit_free_rule_rcu(struct rcu_head *);
> +extern int audit_del_rule(struct audit_entry *entry);
> +extern void audit_free_rule_rcu(struct rcu_head *head);
>  extern struct list_head audit_filter_list[];
>  
>  extern struct audit_entry *audit_dupe_rule(struct audit_krule *old);
> @@ -301,17 +301,17 @@ extern int audit_exe_compare(struct task_struct *tsk, struct audit_fsnotify_mark
>  #endif /* CONFIG_AUDIT_WATCH */
>  
>  #ifdef CONFIG_AUDIT_TREE
> -extern struct audit_chunk *audit_tree_lookup(const struct inode *);
> -extern void audit_put_chunk(struct audit_chunk *);
> -extern bool audit_tree_match(struct audit_chunk *, struct audit_tree *);
> -extern int audit_make_tree(struct audit_krule *, char *, u32);
> -extern int audit_add_tree_rule(struct audit_krule *);
> -extern int audit_remove_tree_rule(struct audit_krule *);
> +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode);
> +extern void audit_put_chunk(struct audit_chunk *chunk);
> +extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree);
> +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op);
> +extern int audit_add_tree_rule(struct audit_krule *rule);
> +extern int audit_remove_tree_rule(struct audit_krule *rule);
>  extern void audit_trim_trees(void);
>  extern int audit_tag_tree(char *old, char *new);
> -extern const char *audit_tree_path(struct audit_tree *);
> -extern void audit_put_tree(struct audit_tree *);
> -extern void audit_kill_trees(struct list_head *);
> +extern const char *audit_tree_path(struct audit_tree *tree);
> +extern void audit_put_tree(struct audit_tree *tree);
> +extern void audit_kill_trees(struct list_head *list);
>  #else
>  #define audit_remove_tree_rule(rule) BUG()
>  #define audit_add_tree_rule(rule) -EINVAL
> @@ -323,7 +323,7 @@ extern void audit_kill_trees(struct list_head *);
>  #define audit_kill_trees(list) BUG()
>  #endif
>  
> -extern char *audit_unpack_string(void **, size_t *, size_t);
> +extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len);
>  
>  extern pid_t audit_sig_pid;
>  extern kuid_t audit_sig_uid;
> @@ -333,7 +333,7 @@ extern int audit_filter(int msgtype, unsigned int listtype);
>  
>  #ifdef CONFIG_AUDITSYSCALL
>  extern int audit_signal_info(int sig, struct task_struct *t);
> -extern void audit_filter_inodes(struct task_struct *, struct audit_context *);
> +extern void audit_filter_inodes(struct task_struct *tsk, struct audit_context *ctx);
>  extern struct list_head *audit_killed_trees(void);
>  #else
>  #define audit_signal_info(s,t) AUDIT_DISABLED
> -- 
> 2.13.0
> 
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

  reply	other threads:[~2017-06-12 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  2:33 Derek Robson
2017-06-12 14:00 ` Richard Guy Briggs [this message]
2017-06-12 22:17 ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612140044.GD21241@madcap2.tricolour.ca \
    --to=rgb@redhat.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=robsonde@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®