From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbdFLSH4 (ORCPT ); Mon, 12 Jun 2017 14:07:56 -0400 Received: from mga07.intel.com ([134.134.136.100]:44145 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdFLSHz (ORCPT ); Mon, 12 Jun 2017 14:07:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,334,1493708400"; d="scan'208";a="1159568995" Date: Mon, 12 Jun 2017 11:07:54 -0700 From: "Luck, Tony" To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll Message-ID: <20170612180753.mjoutdtp3mgpqqvp@intel.com> References: <1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > - severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); > - > - if (severity == MCE_DEFERRED_SEVERITY && mce_is_memory_error(&m)) > - if (m.status & MCI_STATUS_ADDRV) > - m.severity = severity; > + m.severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); So that isn't quite the same. Before we only set m.severity for memory errors where we had a valid address. Now you unconditionally set it. Maybe that's more useful. But it now needs an audit of the code the registered notifiers to make sure they didn't assume that severity set meant that this is a memory error. -Tony