From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com,
rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>
Subject: Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number
Date: Mon, 12 Jun 2017 14:37:33 -0400 [thread overview]
Message-ID: <20170612183733.GJ19206@htj.duckdns.org> (raw)
In-Reply-To: <20170612182028.GH19206@htj.duckdns.org>
Ooh, one more thing.
On Mon, Jun 12, 2017 at 02:20:28PM -0400, Tejun Heo wrote:
> > +struct kernfs_node *kernfs_get_node_by_ino(struct kernfs_root *root,
> > + unsigned int ino)
Can we name this kernfs_find_and_get_by_ino() for consistency? And
the RCU optimization does seem prominent compared to other find/get
functions which all just use kernfs_mutex (still not objecting).
Thanks.
--
tejun
next prev parent reply other threads:[~2017-06-12 18:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 21:53 [PATCH 00/11]blktrace: output cgroup info Shaohua Li
2017-06-02 21:53 ` [PATCH 01/11] kernfs: implement i_generation Shaohua Li
2017-06-02 21:53 ` [PATCH 02/11] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-06-12 18:14 ` Tejun Heo
2017-06-02 21:53 ` [PATCH 03/11] kernfs: add an API to get kernfs node from " Shaohua Li
2017-06-02 22:03 ` Eduardo Valentin
2017-06-02 23:36 ` Shaohua Li
2017-06-12 18:20 ` Tejun Heo
2017-06-12 18:37 ` Tejun Heo [this message]
2017-06-02 21:53 ` [PATCH 04/11] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-06-12 18:29 ` Tejun Heo
2017-06-02 21:53 ` [PATCH 05/11] kernfs: add exportfs operations Shaohua Li
2017-06-02 21:53 ` [PATCH 06/11] cgroup: export fhandle info for a cgroup Shaohua Li
2017-06-12 18:44 ` Tejun Heo
2017-06-02 21:54 ` [PATCH 07/11] blktrace: export cgroup info in trace Shaohua Li
2017-06-03 5:35 ` kbuild test robot
2017-06-02 21:54 ` [PATCH 08/11] block: always attach cgroup info into bio Shaohua Li
2017-06-12 18:49 ` Tejun Heo
2017-06-02 21:54 ` [PATCH 09/11] block: call __bio_free in bio_endio Shaohua Li
2017-06-02 21:54 ` [PATCH 10/11] blktrace: add an option to allow displying cgroup path Shaohua Li
2017-06-02 21:54 ` [PATCH 11/11] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li
2017-06-03 1:09 ` kbuild test robot
2017-06-03 2:00 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612183733.GJ19206@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®