From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbdFMIcm (ORCPT ); Tue, 13 Jun 2017 04:32:42 -0400 Received: from elvis.franken.de ([193.175.24.41]:34386 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdFMIck (ORCPT ); Tue, 13 Jun 2017 04:32:40 -0400 Date: Tue, 13 Jun 2017 10:32:27 +0200 From: Tom Bogendoerfer To: Florian Fainelli Cc: andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk Subject: Re: [net-next] net: phy: marvell: Show complete link partner advertising Message-ID: <20170613083227.GA20254@alpha.franken.de> References: <20170612133237.E20945085BC@solo.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2017 at 09:05:04AM -0700, Florian Fainelli wrote: > On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > > From: Thomas Bogendoerfer > > > > Give back all modes advertised by the link partner. This change brings > > the marvell phy driver in line with all other phy drivers. > > > > Signed-off-by: Thomas Bogendoerfer > > I thought Russell had a similar patch but I can't find it applied in > net-next, so: > > Reviewed-by: Florian Fainelli > > drivers/net/phy/lxt.c has a similar pattern that would be worth fixing too. that's different and correct. The lpa value is not exported as lp_advertising, but only used internal. Well the bug here is IMHO, that it doesn't export lpa to lp_advertising at all as it's done in genphy_read_status(). And from a quick grep there are more phy drivers doing that... I'll have a look later. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]