From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbdFMVq7 (ORCPT ); Tue, 13 Jun 2017 17:46:59 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39466 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbdFMVq6 (ORCPT ); Tue, 13 Jun 2017 17:46:58 -0400 Date: Tue, 13 Jun 2017 22:46:48 +0100 From: Mark Brown To: John Stultz Cc: Kuninori Morimoto , lkml , Zhangfei Gao , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Wei Xu , Rob Herring , Andy Green , Dave Long , Guodong Xu , Antonio Borneo , Olof Johansson , Arnd Bergmann Message-ID: <20170613214648.auh7efw4db5cgwvx@sirena.org.uk> References: <1497300766-23675-1-git-send-email-john.stultz@linaro.org> <20170612221036.zmcv7bluqdyky5ce@sirena.org.uk> <87fuf43aos.wl%kuninori.morimoto.gx@renesas.com> <20170613195416.ipsmch6h3vwwjpvq@sirena.org.uk> <20170613201622.vsayegsiynfq3uix@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gixq6gdzsmbxji3u" Content-Disposition: inline In-Reply-To: X-Cookie: Life is the urge to ecstasy. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi audio support X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gixq6gdzsmbxji3u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 13, 2017 at 01:42:15PM -0700, John Stultz wrote: > Its a trivial bit of code, but its in the drm directory and I suspect > at this stage I'm not going to be able to get maintainer attention for > it in time for 4.13 (plus since it depends on things in the ASoC tree, > so it needs cross-maintainer acks and probably to go through the ASoC > tree). Can I apply it directly? Given that it's all ASoC code it might be the most expedient way to handle this. It doesn't look like there's any DRM changes to meaningfully conflict with. > Plus the new dts changes with the graph need review (where as the > existing ones have been sent out 5 or so times w/o comment) before > they are merged. Its just a ton of extra friction that doesn't gain > much and just keeps functionality from working upstream. What's happened here is that because you've been sending it for so long the code around it changed so there's new review comments. > As for your concern about follow up, I've got the patches lined up here: > https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=31e8b980d93087cf30cd708fb0b2cc48e906d003 > https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=f24a0ccdeeb46ce3eb8864fd43f7a34c673ff9da > And will revise and submit the adv7511 one for initial review today. > So again, I'm happy to migrate over. But I just think, as the graph > stuff doesn't actually benefit us much in this specific case (there is > only one supported audio out path right now), its not worth blocking > getting the functionality working upstream for another 3-6 months. If it might take two kernel releases to get such a trivial change in then that's not giving me a warm fuzzy feeling... there's something not working very well with the HiKey support overall with frequent process problems (only today I had someone resubmitting already applied code). --gixq6gdzsmbxji3u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllAXUgACgkQJNaLcl1U h9DKYQf/ciZpTrIgnPllLObVNAaeDp0mc61dyPCClwhfq4+nj5ieeFf/TCG57G9h P8PoHMxIsNHSZyZPwm+PFcNNPdq65hPSEGQjk6r0N7tO09vtjxSa7PrkgAmjuIK8 DwtnOQpIcjMHIaJndBxaL502XjFTP5cPILuY4LF9f5l7IjqwphRAtf9Cc385H2GQ 66L6gyyDYHKhYdGv867qy9aE9TyC7D7BwFbTkqHLSDMhTDOWl8ExxKPAZbvHaiC6 y0nXMxgcU06tv3LSbU0da8YqhjwIVXVEqe6yeXHxdMiTe3uyJmAR6gHoRvJE2dPr 7e29Bquj4/aGTstu83BvpCDZ2Z1MJA== =DRkD -----END PGP SIGNATURE----- --gixq6gdzsmbxji3u--