From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@kernel.org, corbet@lwn.net
Subject: Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding
Date: Wed, 14 Jun 2017 02:14:56 +0100 [thread overview]
Message-ID: <20170614021456.18356ef1@alans-desktop> (raw)
In-Reply-To: <1497288375-3559-7-git-send-email-tal.shorer@gmail.com>
On Mon, 12 Jun 2017 20:26:13 +0300
Tal Shorer <tal.shorer@gmail.com> wrote:
> The user can issue USB_F_GET_LINE_CODING to get the current line coding
> as set by the host (or the default if unset yet).
No this is not how to do it. We don't want weirdass ioctls for each
different tty device type.
There are two ways this can work. The first is actually done by plenty of
real physical hardware and that is to simply update the termios of the
logical channel to reflect the settings negotiated by the link layer
below (in your course USB ACM).
If that isn't sufficient then implement an ioctl that could work for *ALL*
tty devices - for example return a termios structure indicating the
relevant values on top of the current tty termios settings not some USB
ACM magic object.
Alan
next prev parent reply other threads:[~2017-06-14 1:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 17:26 [PATCH 0/8] Allow f_acm gadgets to notify the user about SetLineCoding requests Tal Shorer
2017-06-12 17:26 ` [PATCH 1/8] tty: add a poll() callback in struct tty_operations Tal Shorer
2017-06-12 17:26 ` [PATCH 2/8] usb: gadget: u_serial: propagate poll() to the next layer Tal Shorer
2017-06-12 17:26 ` [PATCH 3/8] usb: gadget: f_acm: validate set_line_coding requests Tal Shorer
2017-06-12 17:26 ` [PATCH 4/8] usb: gadget: u_serial: propagate ioctl() to the next layer Tal Shorer
2017-06-12 17:26 ` [PATCH 5/8] usb: gadget: f_acm: initialize port_line_coding when creating an instance Tal Shorer
2017-06-12 17:26 ` [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding Tal Shorer
2017-06-12 18:02 ` Tal Shorer
2017-06-12 18:15 ` Tal Shorer
2017-06-14 1:14 ` Alan Cox [this message]
2017-06-12 17:26 ` [PATCH 7/8] usb: gadget: f_acm: notify the user on SetLineCoding Tal Shorer
2017-06-12 17:26 ` [PATCH 8/8] usb: gadget: u_serial: remove port_line_config from struct gserial Tal Shorer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614021456.18356ef1@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®