From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbdFNFIt (ORCPT ); Wed, 14 Jun 2017 01:08:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbdFNFIs (ORCPT ); Wed, 14 Jun 2017 01:08:48 -0400 Date: Wed, 14 Jun 2017 07:08:39 +0200 From: Greg Kroah-Hartman To: Gleb Fotengauer-Malinovskiy Cc: Laura Abbott , linux-kernel@vger.kernel.org, Sumit Semwal , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , devel@driverdev.osuosl.org, "Dmitry V. Levin" Subject: Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls Message-ID: <20170614050839.GB11953@kroah.com> References: <20170530141128.GA1469@glebfm.cloud.tilaa.com> <3725e052-5e57-3455-01e2-76ee33eeb15b@redhat.com> <20170613181704.GD2828@glebfm.cloud.tilaa.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613181704.GD2828@glebfm.cloud.tilaa.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2017 at 09:17:05PM +0300, Gleb Fotengauer-Malinovskiy wrote: > On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote: > > On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote: > > > This problem was found by strace ioctl list generator. > > > > > > Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client") > > As this commit fixes a regression, please apply it to the tree which will > be merged before 4.12 release, too. What "regression" is there? The fact that a staging driver has a few spare ioctls floating around in a header file? How is that bad? thanks, greg k-h