From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbdFNFeA (ORCPT ); Wed, 14 Jun 2017 01:34:00 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35772 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdFNFd6 (ORCPT ); Wed, 14 Jun 2017 01:33:58 -0400 Date: Wed, 14 Jun 2017 07:33:54 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Andi Kleen , David Ahern , Eugeniu Rosca , Hendrik Brueckner , Jan Stancek , Jiada Wang , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Peter Zijlstra , Ravi Bangoria , Rui Teng , Sukadev Bhattiprolu , Wang Nan , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 0/2] perf/urgent fixes for 4.12 Message-ID: <20170614053354.dxiqlhbxpszunozc@gmail.com> References: <20170613232343.4365-1-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613232343.4365-1-acme@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > Test results at the end of this message, as usual. > > The following changes since commit 47c1ded7fef108c730b803cd386241beffcdd15c: > > Merge tag 'perf-urgent-for-mingo-4.12-20170608' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-06-09 00:41:33 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.12-20170613 > > for you to fetch changes up to 9e0c6fd15fcaea39784d1fb3e9fc573f1cf0ae60: > > perf tools: Fix build with ARCH=x86_64 (2017-06-13 16:20:37 -0300) > > ---------------------------------------------------------------- > perf/urgent fixes: > > - Fix probing of precise_ip level for default cycles event, that > got broken recently on x86_64 when its arch code started > considering invalid requesting precise samples when not sampling > (i.e. when attr.sample_period == 0). > > This also fixes another problem in s/390 where the precision > probing with sample_period == 0 returned precise_ip > 0, that > then, when setting up the real cycles event (not probing) would > return EOPNOTSUPP for precise_ip > 0 (as determined previously > by probing) and sample_period > 0. > > These problems resulted in attr_precise not being set to the > highest precision available on x86.64 when no event was specified, > i.e. the canonical: > > perf record ./workload > > would end up using attr.precise_ip = 0. As a workaround this would > need to be done: > > perf record -e cycles:P ./workload > > And on s/390 it would plain not work, requiring using: > > perf record -e cycles ./workload > > as a workaround. (Arnaldo Carvalho de Melo) > > - Fix perf build with ARCH=x86_64, when ARCH should be transformed > into ARCH=x86, just like with the main kernel Makefile and > tools/objtool's, i.e. use SRCARCH. (Jiada Wang) > > Signed-off-by: Arnaldo Carvalho de Melo > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (1): > perf evsel: Fix probing of precise_ip level for default cycles event > > Jiada Wang (1): > perf tools: Fix build with ARCH=x86_64 > > tools/perf/Makefile.config | 38 +++++++++++++++++++------------------- > tools/perf/Makefile.perf | 2 +- > tools/perf/arch/Build | 2 +- > tools/perf/pmu-events/Build | 4 ++-- > tools/perf/tests/Build | 2 +- > tools/perf/tests/task-exit.c | 2 +- > tools/perf/util/evsel.c | 5 +++++ > tools/perf/util/header.c | 2 +- > 8 files changed, 31 insertions(+), 26 deletions(-) Pulled, thanks a lot Arnaldo! Ingo