From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310AbdFNHHZ (ORCPT ); Wed, 14 Jun 2017 03:07:25 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:48138 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbdFNHHY (ORCPT ); Wed, 14 Jun 2017 03:07:24 -0400 Date: Wed, 14 Jun 2017 09:07:12 +0200 From: Maxime Ripard To: Kevin Hilman Cc: Rask Ingemann Lambertsen , Chen-Yu Tsai , Russell King , linux-arm-kernel , lkml Subject: Re: [PATCH 4/4] ARM: multi_v7_defconfig: Switch AXP20x driver from module to built-in Message-ID: <20170614070712.yos54lelz5adrlq6@flea.lan> References: <937914a68e4e7d6db2d12540cc6253b200978e2d.1486590875.git.rask@formelder.dk> <49ad3e66452bd78da7b9e581129f76633c56e609.1486590875.git.rask@formelder.dk> <20170210084213.uzf25soh7bl73a6g@lukather> <20170522074414.3qz2wpw4cs2btkhv@flea.lan> <20170610161714.wiztqlnwz5qu73fz@flea.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opjkfgtoib6lj6y2" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170602 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --opjkfgtoib6lj6y2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 13, 2017 at 09:14:00AM -0700, Kevin Hilman wrote: > Maxime Ripard writes: >=20 > > On Tue, Jun 06, 2017 at 12:45:17PM -0700, Kevin Hilman wrote: > >> On Mon, May 22, 2017 at 12:44 AM, Maxime Ripard > >> wrote: > >> > Hi Kevin, > >> > > >> > On Thu, May 18, 2017 at 11:59:50AM -0700, Kevin Hilman wrote: > >> >> On Fri, Mar 17, 2017 at 10:39 AM, Kevin Hilman wrote: > >> >> > On Fri, Feb 10, 2017 at 12:42 AM, Maxime Ripard > >> >> > wrote: > >> >> >> On Wed, Feb 08, 2017 at 11:09:31PM +0100, Rask Ingemann Lamberts= en wrote: > >> >> >>> The AXP20X regulator support is currently built as a module, wh= ich means > >> >> >>> it's not available until the root fs has been mounted, but the = boot loader > >> >> >>> might not have enabled the required regulators, so build their = drivers > >> >> >>> into the kernel. > >> >> >>> > >> >> >>> Signed-off-by: Rask Ingemann Lambertsen > >> >> >> > >> >> >> Queued for 4.12. > >> >> > > >> >> > Hello, kernelci.org is reporting boot failures on sun5i-r8-chip in > >> >> > linux-next[1] for a few days and with a variety of defconfigs. I > >> >> > bisected it[2] down to this patch. > >> >> > > >> >> > I verified that reverting this patch on top of next-20170310 make= s my > >> >> > chip board boot again. > >> >> > >> >> FYI... this board is still broken in linux-next (and now in mainlin= e), > >> >> and reverting $SUBJECT patch still makes it work. > >> >> > >> >> Is nobody else using mainline on this board? > >> > > >> > I thought about that during the weekend, and it might just be a > >> > symptom. > >> > > >> > The CHIP has brown out issues, especially when you enable the WiFi > >> > chip, which should happen around the time of the failure when the PM= IC > >> > regulator support is compiled as a module. > >> > > >> > We mitigate that in upstream's U-Boot by enabling the two regulators > >> > for the WiFi chip in U-boot, which levels a bit the current over the > >> > boot. > >> > > >> > You have a few ways to prevent that from happening. Having a better > >> > power supply / cable will help, I'm not sure how reasonable that is. > >> > > >> > Another thing that can work is, if your USB plugs can take it, to > >> > increase the overcurrent trigger in the PMIC, ideally in U-Boot. > >> > > >> > The last, and probably cleaner one, would be to just power it through > >> > the 5v input on its header, and not the USB. There's not current > >> > limitation there, so it shouldn't cause any problems anymore. > >>=20 > >> I'm now powering the board via the header (5V to the CHG-IN pin) and > >> it doesn't change anything. Still fails in the same way, and > >> reverting $SUBJECT defconfig patch makes it work again. > > > > I tried it today with sunxi_defconfig that has AXP20X_REGULATOR > > built-in as well. It can boot fine on my CHIP here. >=20 > What about multi_v7_defconfig? It seems to work in our farm. It's lagging behind at the moment, so it hasn't been published yet, but here is the last multi_v7 boot. http://code.bulix.org/a43kkf-147625?raw > > After looking at your failed boot example (1), I'm a bit > > puzzled. Where is supposed to be your filesystem? > > > > You have a ubi rootfs, but we don't have the NAND enabled in mainline, > > so that cannot work. And you seem to load an initramfs earlier in > > U-Boot, but you don't pass it is your bootz call. >=20 > Ah, I suppose that isn't terribly clear from the log. >=20 > My scripts don't rely on uboot for the ramdisk because because (believe > it or not) many vendor uboots don't enable the ATAGs for initrd in > uboot. >=20 > So, I modify the DT to add the linux,initrd-start and linux,initrd-end > properties to the chosen node poining to where the initrd is loaded in > memory. This also avoids the need to add a uimage header to the ramdisk. Ok, good :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --opjkfgtoib6lj6y2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZQOCfAAoJEBx+YmzsjxAgIyYQAIfHJDNYhZmQAKopdlm56mwk 5kajbtrVJiAPz6vi0muLlNXTi4969NOI05ADNlh5GxhnsYqipK1yMhmb0jnpuVja 6apkMRdNd+3GEcpngizlDyVldioKW4DplbKbSjYS1pUrC/ROLCOLU6OeSbvb2NiL I9rTQnEfSmZ+yWjfNdg0nVywU7lpIjPWDCWDNPRytH0c9JZRM146ho9sirxJjCfN VOdHrPOgumV2fCFzw8XjFs0lDOLj9D4y6JzDhFe8HemB6rJ+Pv2w6itrWi1pLBre p17pIjOiLpth0x5dF47y/Ooz0NrzsX5JEDMS4DQfU3etqWNpiQC7fHohId7G4OBm 6cq0CD9qCT1silK5GvVlO6rTnIJHfJ9jHl8vJE+16/+ymbaTy1zMepY9GC1GD3ug peJF3R3e+fIslhaGXOLS1zGC7gNY9+S8FVi/es16rKI2KDzIl9MkHFI4Angv2jTO PHbfVX1XntUtIsV0wZ0w9OA3hsndCk46TVUaazt5icSL7r9alTcHOitZqq59wGDM LA5BKZqfTnFZ3Zyq2mr468o3do+jp4mGX1OMFjAnkjoAkJH3r5YMMYBmFZR8WhGt fNVAiXzokdpy7DqJYaXKy5/1cT8lQWX76LM17eWQHRNp/W14rl+D4bn5a5z4Gvpd E86piiuV3vlg7i1DKZgv =Ini8 -----END PGP SIGNATURE----- --opjkfgtoib6lj6y2--