From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdFNNz3 (ORCPT ); Wed, 14 Jun 2017 09:55:29 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:32858 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbdFNNz1 (ORCPT ); Wed, 14 Jun 2017 09:55:27 -0400 Date: Wed, 14 Jun 2017 15:55:22 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Alexander Shishkin , David Ahern , Namhyung Kim , Peter Zijlstra , Wang Nan Subject: Re: [PATCH 1/2] perf evsel: Fix probing of precise_ip level for default cycles event Message-ID: <20170614135522.onbcuh7aovkto2ld@gmail.com> References: <20170613232343.4365-1-acme@kernel.org> <20170613232343.4365-2-acme@kernel.org> <20170614054500.exocsybw2qkug5tn@gmail.com> <20170614104426.GA32020@kernel.org> <20170614105154.lg5prmc2xfwivjfz@gmail.com> <20170614105740.GB32020@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170614105740.GB32020@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 14, 2017 at 12:51:55PM +0200, Ingo Molnar escreveu: > > > > * Arnaldo Carvalho de Melo wrote: > > > > > Can you try with the patch below, which is hackish but the minimal fix at this > > > point. Later I'll come up with a way of returning a fully configured cycles > > > evsel, which will make the tools code simpler, moving more stuff to the > > > libraries. > > > > Yeah, this patch on top of your tree seems to work better now. > > So how do we proceed, do you want to keep these two as separate or can I > squash them together, fix that problem with the unwind library and > provide a new perf/urgent for you to use? > > Off to breakfast now tho :-) Your call: I had to unpull, so feel free to rebase your urgent branch. Thanks, Ingo