From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbdFNOXz (ORCPT ); Wed, 14 Jun 2017 10:23:55 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53548 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdFNOXy (ORCPT ); Wed, 14 Jun 2017 10:23:54 -0400 Date: Wed, 14 Jun 2017 16:23:51 +0200 From: Borislav Petkov To: Janakarajan Natarajan Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Suravee Suthikulpanit Subject: Re: [PATCH v3 2/2] amd: uncore: Get correct number of cores sharing last level cache Message-ID: <20170614142351.djdrhalokhbprh6y@pd.tnic> References: <229d2e3d941066c3e59bb5cbc9842991d82d956a.1497369024.git.Janakarajan.Natarajan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <229d2e3d941066c3e59bb5cbc9842991d82d956a.1497369024.git.Janakarajan.Natarajan@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2017 at 10:58:28AM -0500, Janakarajan Natarajan wrote: > In Family 17h, the number of cores sharing a cache level is obtained > from the Cache Properties CPUID leaf (0x8000001d) by passing in the > cache level in ECX. In prior families, a cache level of 2 was used to > determine this information. > > To get the right information, irrespective of Family, iterate over > the cache levels using CPUID 0x8000001d. The last level cache is the > last value to return a non-zero value in EAX. > > Signed-off-by: Janakarajan Natarajan > --- > arch/x86/events/amd/uncore.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/events/amd/uncore.c b/arch/x86/events/amd/uncore.c > index e34f8a6..a0b33de 100644 > --- a/arch/x86/events/amd/uncore.c > +++ b/arch/x86/events/amd/uncore.c > @@ -400,11 +400,24 @@ static int amd_uncore_cpu_starting(unsigned int cpu) > > if (amd_uncore_llc) { > unsigned int apicid = cpu_data(cpu).apicid; > - unsigned int nshared; > + unsigned int nshared, subleaf, prev_eax = 0; > > uncore = *per_cpu_ptr(amd_uncore_llc, cpu); > - cpuid_count(0x8000001d, 2, &eax, &ebx, &ecx, &edx); > - nshared = ((eax >> 14) & 0xfff) + 1; > + /* > + * Iterate over Cache Topology Definition leaves until no > + * more cache descriptions are available. > + */ > + for(subleaf = 0; subleaf < 5; subleaf++) { ERROR: space required before the open parenthesis '(' #51: FILE: arch/x86/events/amd/uncore.c:410: + for(subleaf = 0; subleaf < 5; subleaf++) { Please integrate scripts/checkpatch.pl in your patch creation workflow. Some of the warnings/errors *actually* make sense. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.