From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbdFOLsS (ORCPT ); Thu, 15 Jun 2017 07:48:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:43916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbdFOLsR (ORCPT ); Thu, 15 Jun 2017 07:48:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4765214E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 15 Jun 2017 07:48:13 -0400 From: Steven Rostedt To: Michal Hocko Cc: Vlastimil Babka , David Rientjes , Johannes Weiner , Andrew Morton , LKML Subject: Re: [PATCH] oom, trace: Remove ENUM evaluation of COMPACTION_FEEDBACK Message-ID: <20170615074813.1ed10a07@gandalf.local.home> In-Reply-To: <20170615105720.GH1486@dhcp22.suse.cz> References: <20170615064823.273fa96e@gandalf.local.home> <20170615105720.GH1486@dhcp22.suse.cz> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2017 12:57:21 +0200 Michal Hocko wrote: > > #define COMPACTION_FEEDBACK \ > > EM(COMPACTION_FAILED, "failed") \ > > EM(COMPACTION_WITHDRAWN, "withdrawn") \ > > EMe(COMPACTION_PROGRESS, "progress") > > > > Which is still needed for the __print_symbolic() usage in the > > trace_event. But it is not needed to be evaluated. > > > > Removing the evaluation part removes the unnecessary evaluations of > > numbers to numbers. > > I will be honest with you. Even if I understood how this voodoo mapping > works I forgot everything. So if the COMPACTION_*->names keeps working > I have no objection to the patch. Yes it does. It you want to verify, simply boot the kernel without the patch and do: # cat /sys/kernel/debug/tracing/events/*/*/format > ~/formats1 Add the patch, compile and boot that kernel. # cat /sys/kernel/debug/tracing/events/*/*/format > ~/formats2 then: # diff formats1 formats2 and they should be the same, with the exception that the ID:'s can change. Also, let me send a v2. Resending this patch (from the private one) seems to broke the format of it. -- Steve