From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdFOJ6s (ORCPT ); Thu, 15 Jun 2017 05:58:48 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:34212 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbdFOJ6q (ORCPT ); Thu, 15 Jun 2017 05:58:46 -0400 Date: Thu, 15 Jun 2017 15:28:43 +0530 From: Viresh Kumar To: Colin King Cc: "Rafael J . Wysocki" , linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: sfi: make freq_table static Message-ID: <20170615095843.GA3942@vireshk-i7> References: <20170615095559.21973-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615095559.21973-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-06-17, 10:55, Colin King wrote: > From: Colin Ian King > > pointer freq_table can be made static as it does not need to be in > global scope. > > Cleans up sparse warning: > "symbol 'freq_table' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > drivers/cpufreq/sfi-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c > index 992ce6f9abec..3779742f86e3 100644 > --- a/drivers/cpufreq/sfi-cpufreq.c > +++ b/drivers/cpufreq/sfi-cpufreq.c > @@ -24,7 +24,7 @@ > > #include > > -struct cpufreq_frequency_table *freq_table; > +static struct cpufreq_frequency_table *freq_table; > static struct sfi_freq_table_entry *sfi_cpufreq_array; > static int num_freq_table_entries; Acked-by: Viresh Kumar -- viresh