From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbdFONOe (ORCPT ); Thu, 15 Jun 2017 09:14:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbdFONOc (ORCPT ); Thu, 15 Jun 2017 09:14:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6AAF319D611 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6AAF319D611 Date: Thu, 15 Jun 2017 08:14:31 -0500 From: Josh Poimboeuf To: Kees Cook Cc: linux-kernel@vger.kernel.org, Daniel Micay , Stephen Rothwell Subject: Re: [PATCH] objtool: Add fortify_panic as __noreturn function Message-ID: <20170615131431.zv5ssibdg3csg4d5@treble> References: <20170615021851.GA83998@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170615021851.GA83998@beast> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 15 Jun 2017 13:14:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 14, 2017 at 07:18:51PM -0700, Kees Cook wrote: > CONFIG_FORTIFY_SOURCE implements fortify_panic() as a __noreturn function, > so objtool needs to know about it too. > > Suggested-by: Daniel Micay > Signed-off-by: Kees Cook > Cc: Josh Poimboeuf > --- > tools/objtool/builtin-check.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c > index 282a60368b14..5f66697fe1e0 100644 > --- a/tools/objtool/builtin-check.c > +++ b/tools/objtool/builtin-check.c > @@ -192,7 +192,8 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, > "complete_and_exit", > "kvm_spurious_fault", > "__reiserfs_panic", > - "lbug_with_loc" > + "lbug_with_loc", > + "fortify_panic", > }; > > if (func->bind == STB_WEAK) Thanks, I'll take the patch. Eventually I'd like to experiment with a GCC plugin to automatically detect these noreturn cases instead of the hard-coded list. -- Josh