From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbdFOPMG (ORCPT ); Thu, 15 Jun 2017 11:12:06 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33306 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbdFOPMF (ORCPT ); Thu, 15 Jun 2017 11:12:05 -0400 From: nobble X-Google-Original-From: nobble Date: Thu, 15 Jun 2017 23:11:59 +0800 To: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers:pcmcia:m32r_pcc:Check return value of request_region() Message-ID: <20170615151159.GA3016@rjk-ThinkPad-E560> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org request_region() can fail here and check its return value Signed-off-by: nobbleRen --- drivers/pcmcia/m32r_pcc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pcmcia/m32r_pcc.c b/drivers/pcmcia/m32r_pcc.c index e50bbf8..5ab241a 100644 --- a/drivers/pcmcia/m32r_pcc.c +++ b/drivers/pcmcia/m32r_pcc.c @@ -316,7 +316,8 @@ static int add_pcc_socket(ulong base, int irq, ulong mapaddr, /* add pcc */ if (t->base > 0) { - request_region(t->base, 0x20, "m32r-pcc"); + if (!request_region(t->base, 0x20, "m32r-pcc")) + return -EBUSY; } printk(KERN_INFO " %s ", pcc[pcc_sockets].name); -- 1.9.1