From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yao Lihua <ylhuajnu@163.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sergio Prado <sergio.prado@e-labworks.com>,
stable@vger.kernel.org, Donglin Peng <dolinux.peng@gmail.com>
Subject: Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx
Date: Thu, 15 Jun 2017 17:28:36 +0200 [thread overview]
Message-ID: <20170615152836.j6y4k4ydkterifii@kozik-lap> (raw)
In-Reply-To: <44ca46f9-0607-d750-4f26-eab717518fd9@163.com>
On Thu, Jun 15, 2017 at 10:42:30PM +0800, Yao Lihua wrote:
> Hi Krzysztof,
>
> Another Oops on S3C6410.
(...)
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > index f542642eed8d..a25c3ffae25c 100644
> > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > @@ -1013,6 +1013,11 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
> > bank->eint_base = virt_base[0];
> > bank->pctl_base = virt_base[bdata->pctl_res_idx];
> > }
> > + /*
> > + * For legacy platforms which need to access IO memory through
> > + * samsung_pinctrl_drv_data:
> > + */
> > + d->virt_base = virt_base[bdata->pctl_res_idx];
> >
> for (i = 0; i < ctrl->nr_banks; ++i, ++bdata, ++bank) {
> ......
> }
> /*
> * For legacy platforms which need to access IO memory through
> * samsung_pinctrl_drv_data:
> */
> d->virt_base = virt_base[bdata->pctl_res_idx];
> ^
> **bdata** is invalid here.
Ah, of course, apparently it worked in my case by coincidence. Thanks
for spotting this.
Best regards,
Krzysztof
prev parent reply other threads:[~2017-06-15 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 13:18 Krzysztof Kozlowski
2017-06-14 13:18 ` [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts Krzysztof Kozlowski
2017-06-16 14:08 ` Sylwester Nawrocki
2017-06-20 10:31 ` Sylwester Nawrocki
2017-06-15 14:42 ` [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx Yao Lihua
2017-06-15 15:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615152836.j6y4k4ydkterifii@kozik-lap \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dolinux.peng@gmail.com \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sergio.prado@e-labworks.com \
--cc=stable@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=ylhuajnu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®