From: Logan Gunthorpe <logang@deltatee.com>
To: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Stephen Bates <sbates@raithlin.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver
Date: Thu, 15 Jun 2017 14:37:18 -0600 [thread overview]
Message-ID: <20170615203729.9009-3-logang@deltatee.com> (raw)
In-Reply-To: <20170615203729.9009-1-logang@deltatee.com>
We switch to class_register/unregister and a declared class which
is exported for use in the switchtec_ntb driver.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Stephen Bates <sbates@raithlin.com>
Reviewed-by: Kurt Schwemmer <kurt.schwemmer@microsemi.com>
---
drivers/pci/switch/switchtec.c | 21 +++++++++++----------
include/linux/switchtec.h | 2 ++
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index c4369ba7bbc1..e9bf17b1934e 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -21,8 +21,6 @@
#include <linux/fs.h>
#include <linux/uaccess.h>
#include <linux/poll.h>
-#include <linux/pci.h>
-#include <linux/cdev.h>
#include <linux/wait.h>
MODULE_DESCRIPTION("Microsemi Switchtec(tm) PCIe Management Driver");
@@ -35,9 +33,14 @@ module_param(max_devices, int, 0644);
MODULE_PARM_DESC(max_devices, "max number of switchtec device instances");
static dev_t switchtec_devt;
-static struct class *switchtec_class;
static DEFINE_IDA(switchtec_minor_ida);
+struct class switchtec_class = {
+ .owner = THIS_MODULE,
+ .name = "switchtec",
+};
+EXPORT_SYMBOL(switchtec_class);
+
enum mrpc_state {
MRPC_IDLE = 0,
MRPC_QUEUED,
@@ -1026,7 +1029,7 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev)
dev = &stdev->dev;
device_initialize(dev);
- dev->class = switchtec_class;
+ dev->class = &switchtec_class;
dev->parent = &pdev->dev;
dev->groups = switchtec_device_groups;
dev->release = stdev_release;
@@ -1313,11 +1316,9 @@ static int __init switchtec_init(void)
if (rc)
return rc;
- switchtec_class = class_create(THIS_MODULE, "switchtec");
- if (IS_ERR(switchtec_class)) {
- rc = PTR_ERR(switchtec_class);
+ rc = class_register(&switchtec_class);
+ if (rc)
goto err_create_class;
- }
rc = pci_register_driver(&switchtec_pci_driver);
if (rc)
@@ -1328,7 +1329,7 @@ static int __init switchtec_init(void)
return 0;
err_pci_register:
- class_destroy(switchtec_class);
+ class_unregister(&switchtec_class);
err_create_class:
unregister_chrdev_region(switchtec_devt, max_devices);
@@ -1340,7 +1341,7 @@ module_init(switchtec_init);
static void __exit switchtec_exit(void)
{
pci_unregister_driver(&switchtec_pci_driver);
- class_destroy(switchtec_class);
+ class_unregister(&switchtec_class);
unregister_chrdev_region(switchtec_devt, max_devices);
ida_destroy(&switchtec_minor_ida);
diff --git a/include/linux/switchtec.h b/include/linux/switchtec.h
index 508cda78a430..3b87618fc42f 100644
--- a/include/linux/switchtec.h
+++ b/include/linux/switchtec.h
@@ -267,4 +267,6 @@ static inline struct switchtec_dev *to_stdev(struct device *dev)
return container_of(dev, struct switchtec_dev, dev);
}
+extern struct class switchtec_class;
+
#endif
--
2.11.0
next prev parent reply other threads:[~2017-06-15 20:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 20:37 [RFC PATCH 00/13] Switchtec NTB Support Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 01/13] switchtec: move structure definitions into a common header Logan Gunthorpe
2017-06-17 5:11 ` Greg Kroah-Hartman
2017-06-15 20:37 ` Logan Gunthorpe [this message]
2017-06-17 5:11 ` [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver Greg Kroah-Hartman
2017-06-17 16:16 ` Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 03/13] switchtec: add ntb hardware register definitions Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 04/13] switchtec: add link event notifier block Logan Gunthorpe
2017-06-17 5:14 ` Greg Kroah-Hartman
2017-06-17 16:20 ` Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 05/13] switchtec_ntb: introduce initial ntb driver Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 06/13] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe
2017-06-17 5:16 ` Greg Kroah-Hartman
2017-06-17 16:39 ` Logan Gunthorpe
2017-06-18 0:33 ` Greg Kroah-Hartman
2017-06-15 20:37 ` [RFC PATCH 07/13] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 08/13] switchtec_ntb: add skeleton ntb driver Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 09/13] switchtec_ntb: add link management Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 10/13] switchtec_ntb: implement doorbell registers Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 11/13] switchtec_ntb: implement scratchpad registers Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 12/13] switchtec_ntb: add memory window support Logan Gunthorpe
2017-06-15 20:37 ` [RFC PATCH 13/13] switchtec_ntb: update switchtec documentation with notes for ntb Logan Gunthorpe
2017-06-16 13:53 ` [RFC PATCH 00/13] Switchtec NTB Support Allen Hubbe
2017-06-16 14:09 ` Logan Gunthorpe
2017-06-16 15:34 ` Allen Hubbe
2017-06-16 16:47 ` Logan Gunthorpe
2017-06-16 17:39 ` Serge Semin
2017-06-16 18:08 ` Allen Hubbe
2017-06-16 19:17 ` Logan Gunthorpe
2017-06-16 16:33 ` Serge Semin
2017-06-16 17:08 ` Logan Gunthorpe
2017-06-16 18:38 ` Serge Semin
2017-06-16 19:34 ` Logan Gunthorpe
2017-06-16 20:21 ` Serge Semin
2017-06-17 5:09 ` 'Greg Kroah-Hartman'
2017-06-17 16:11 ` Logan Gunthorpe
2017-06-17 16:15 ` Logan Gunthorpe
2017-06-19 19:14 ` Jon Mason
2017-06-19 20:07 ` Jon Mason
2017-06-19 20:27 ` Logan Gunthorpe
2017-06-19 21:09 ` Jon Mason
2017-06-22 16:17 ` New NTB API Issue Logan Gunthorpe
2017-06-22 18:32 ` Allen Hubbe
2017-06-22 18:40 ` Logan Gunthorpe
2017-06-22 22:12 ` Allen Hubbe
2017-06-22 22:19 ` Logan Gunthorpe
2017-06-22 22:42 ` Allen Hubbe
2017-06-22 22:49 ` Logan Gunthorpe
2017-06-23 13:18 ` Allen Hubbe
2017-06-23 16:51 ` Logan Gunthorpe
2017-06-23 19:07 ` Allen Hubbe
2017-06-23 20:39 ` Logan Gunthorpe
2017-06-23 22:06 ` Allen Hubbe
2017-06-23 23:06 ` Logan Gunthorpe
2017-06-23 21:47 ` Serge Semin
2017-06-23 21:59 ` Logan Gunthorpe
2017-06-23 22:01 ` Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615203729.9009-3-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome