From: Rob Herring <robh@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] of: Custom printk format specifier for device node
Date: Thu, 15 Jun 2017 16:26:16 -0500 [thread overview]
Message-ID: <20170615212616.2uakwphhphkdds4g@rob-hp-laptop> (raw)
In-Reply-To: <1497473808.18751.70.camel@perches.com>
On Wed, Jun 14, 2017 at 01:56:48PM -0700, Joe Perches wrote:
> On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote:
> > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>
> I think the commit subject is wrong.
> It adds an "of" specific bit to vsprintf.c.
> The subject should be
> 'vsprintf: Add %p extension "%pO" for device tree'
>
> > 90% of the usage of device node's full_name is printing it out
> > in a kernel message. Preparing for the eventual delayed allocation
> > introduce a custom printk format specifier that is both more
> > compact and more pleasant to the eye.
> >
> > For instance typical use is:
> > pr_info("Frobbing node %s\n", node->full_name);
> >
> > Which can be written now as:
> > pr_info("Frobbing node %pOF\n", node);
>
> Somehow I think this example is poor as node->full_name
> is a pretty obvious to read use. %pOF requires you to
> look up or know what the output is going to be.
>
> > More fine-grained control of formatting includes printing the name,
> > flag, path-spec name, reference count and others, explained in the
> > documentation entry.
> >
> > Originally written by Pantelis, but pretty much rewrote the core
> > function using existing string/number functions. The 2 passes were
> > unnecessary and have been removed. Also, updated the checkpatch.pl
> > check.
>
> Some comments about the code.
>
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > []
> > @@ -1470,6 +1471,123 @@ char *flags_string(char *buf, char *end, void *flags_ptr, const char *fmt)
> > return format_flags(buf, end, flags, names);
> > }
> >
> > +static noinline_for_stack
> > +char *device_node_gen_full_name(const struct device_node *np, char *buf, char *end)
> > +{
> > + int len, ret;
> > +
> > + if (!np || !np->parent)
> > + return buf;
> > +
> > + buf = device_node_gen_full_name(np->parent, buf, end);
>
> This is recursive. How many levels of parents could there be?
> Perhaps there should be a recursion limit.
Okay, unlike unflattening code, we can easily calculate the depth and
then allocate an array on the stack. So this is what I've ended up
with:
static int device_node_calc_depth(const struct device_node *np)
{
int d;
for (d = 0; np; d++)
np = np->parent;
return d;
}
static noinline_for_stack
char *device_node_gen_full_name(const struct device_node *np, char *buf, char *end)
{
int i;
int depth = device_node_calc_depth(np);
const struct device_node *nodes[depth];
const struct printf_spec strspec = {
.field_width = -1,
.precision = -1,
};
if (!depth)
return buf;
/* special case for root node */
if (depth == 1)
return string(buf, end, "/", strspec);
depth--;
for (i = depth - 1; i >= 0; i--) {
nodes[i] = np;
np = np->parent;
}
for (i = 0; i < depth; i++) {
buf = string(buf, end, "/", strspec);
buf = string(buf, end, kbasename(nodes[i]->full_name), strspec);
}
return buf;
}
> > + /* simple case without anything any more format specifiers */
> > + if (fmt[1] == '\0' || strcspn(fmt + 1,"fnpPFcCr") > 0)
> > + fmt = "Ff";
> > +
> > + for (fmtp = fmt + 1, pass = false; strspn(fmtp,"fnpPFcCr"); fmtp++, pass = true) {
>
> why not
> while (isalpha(*++fmt))
> like ip6 or isalnum like FORMAT_TYPE_PTR uses?
This case is more complicated with the field separators. If we have
something like %pOFfxyz where xyz are not valid format specifiers, we'd
end up with extra field separators.
I did simplify things a bit and got rid of fmtp and just use fmt
instead.
Rob
next prev parent reply other threads:[~2017-06-15 21:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 20:30 [PATCH 0/4] DT printf format specifiers Rob Herring
2017-06-14 20:30 ` [PATCH 1/4] of: use kbasename instead of open coding Rob Herring
2017-06-17 17:30 ` Andy Shevchenko
2017-06-14 20:30 ` [PATCH 2/4] of: find_node_by_full_name rewrite to compare each level Rob Herring
2017-06-14 20:30 ` [PATCH 3/4] of: Custom printk format specifier for device node Rob Herring
2017-06-14 20:56 ` Joe Perches
2017-06-15 12:30 ` Rob Herring
2017-06-15 16:51 ` Joe Perches
2017-06-15 21:26 ` Rob Herring [this message]
2017-06-15 21:50 ` Joe Perches
2017-06-22 20:44 ` [PATCH v2] vsprintf: Add %p extension "%pOF" for device tree Rob Herring
2017-06-22 22:44 ` Randy Dunlap
2017-06-23 14:08 ` Rob Herring
2017-06-23 3:01 ` Joe Perches
2017-06-23 14:13 ` Rob Herring
2017-06-23 17:30 ` [PATCH v3] " Rob Herring
2017-06-23 17:38 ` Joe Perches
2017-06-14 20:30 ` [PATCH 4/4] of: Convert to using %pOF instead of full_name Rob Herring
2017-06-14 20:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615212616.2uakwphhphkdds4g@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pantelis.antoniou@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®