From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: David Gstir <david@sigma-star.at>,
Dan Douglass <dan.douglass@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Radu Solea <radu.solea@nxp.com>,
"richard@sigma-star.at" <richard@sigma-star.at>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] crypto: caam - fix cts(cbc(aes)) with CAAM driver
Date: Fri, 16 Jun 2017 15:59:41 +0800 [thread overview]
Message-ID: <20170616075941.GA5346@gondor.apana.org.au> (raw)
In-Reply-To: <VI1PR0401MB25913AAA76159D27E8EB13DF98C10@VI1PR0401MB2591.eurprd04.prod.outlook.com>
On Fri, Jun 16, 2017 at 07:57:00AM +0000, Horia Geantă wrote:
>
> Commit 0605c41cc53ca ("crypto: cts - Convert to skcipher") appends
> CRYPTO_TFM_REQ_MAY_BACKLOG to the original crypto request flags for the
> last block - when calling cts_cbc_encrypt().
> Is it really needed?
Yes, because at this point we cannot tell the sender to back off.
> For cts(cbc(aes)) with cbc(aes) offloaded in HW, i.e. running in async
> mode, we get the below stack for CAAM driver.
> Driver is told that it can sleep (CRYPTO_TFM_REQ_MAY_BACKLOG flag), so
> it uses GFP_KERNEL to allocate memory. However, this is incorrect, since
> driver runs in atomic context (softirq).
This is wrong. Whether you can sleep or not is determined by
MAY_SLEEP, not MAY_BACKLOG. MAY_BACKLOG only indicates that this
request must be queued, even if the queue is full.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-06-16 8:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 12:24 David Gstir
2017-06-02 12:24 ` [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt David Gstir
2017-06-19 10:31 ` Horia Geantă
2017-06-20 1:28 ` Herbert Xu
2017-06-26 5:40 ` David Gstir
2017-06-26 6:47 ` Herbert Xu
2017-06-28 8:32 ` Horia Geantă
2017-06-28 9:03 ` David Gstir
2017-06-02 12:24 ` [RFC PATCH 2/2] crypto: caam - fix k*alloc if called from own cipher callback David Gstir
2017-06-13 11:53 ` [RFC PATCH 0/2] crypto: caam - fix cts(cbc(aes)) with CAAM driver David Gstir
2017-06-15 14:57 ` Horia Geantă
2017-06-16 7:57 ` Horia Geantă
2017-06-16 7:59 ` Herbert Xu [this message]
2017-06-16 21:01 ` Horia Geantă
2017-06-17 9:05 ` David Gstir
2017-06-19 8:44 ` [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I) Horia Geantă
2017-06-19 8:44 ` [PATCH 2/2] crypto: caam - fix gfp allocation flags (part II) Horia Geantă
2017-06-22 9:00 ` Herbert Xu
2017-06-22 9:00 ` [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I) Herbert Xu
2017-06-28 13:27 ` [PATCH] crypto: caam - properly set IV after {en,de}crypt David Gstir
2017-06-28 13:42 ` Horia Geantă
2017-06-29 10:19 ` Horia Geantă
2017-08-14 7:59 ` Gilad Ben-Yossef
2017-09-05 15:33 ` Horia Geantă
2017-09-06 10:14 ` Gilad Ben-Yossef
2017-09-07 10:12 ` Horia Geantă
2017-07-12 10:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616075941.GA5346@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dan.douglass@nxp.com \
--cc=davem@davemloft.net \
--cc=david@sigma-star.at \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radu.solea@nxp.com \
--cc=richard@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®