From: Andrew Morton <akpm@linux-foundation.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>,
Babu Moger <babu.moger@oracle.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs
Date: Fri, 16 Jun 2017 11:24:07 -0700 [thread overview]
Message-ID: <20170616112407.e150c215209d86d7e8916a47@linux-foundation.org> (raw)
In-Reply-To: <20170616065715.18390-5-npiggin@gmail.com>
On Fri, 16 Jun 2017 16:57:14 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
> After reconfiguring watchdog sysctls etc., architecture specific
> watchdogs may not get all their parameters updated.
>
> watchdog_reconfigure() can be implemented to pull the new values
> in and set the arch NMI watchdog.
>
I'll update the title and changelog to say "watchdog_nmi_reconfigure".
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -123,6 +123,11 @@ void __weak watchdog_nmi_disable(unsigned int cpu)
> {
> }
>
> +void __weak watchdog_nmi_reconfigure(void)
> +{
> +}
Can we please get some documentation in here describing what it's for?
How arch maintainers might use this? When and why it is called, what
it must do? etc.
next prev parent reply other threads:[~2017-06-16 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 6:57 [PATCH v4 0/5] Improve watchdog config " Nicholas Piggin
2017-06-16 6:57 ` [PATCH v4 1/5] watchdog: remove unused declaration Nicholas Piggin
2017-06-16 6:57 ` [PATCH v4 2/5] watchdog: introduce arch_touch_nmi_watchdog() Nicholas Piggin
2017-06-16 18:21 ` Andrew Morton
2017-06-17 2:43 ` Nicholas Piggin
2017-06-16 6:57 ` [PATCH v4 3/5] watchdog: split up config options Nicholas Piggin
2017-06-17 12:35 ` Nicholas Piggin
2017-06-16 6:57 ` [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs Nicholas Piggin
2017-06-16 18:24 ` Andrew Morton [this message]
2017-06-17 2:59 ` Nicholas Piggin
2017-06-16 6:57 ` [PATCH v4 5/5] powerpc/64s: implement arch-specific hardlockup watchdog Nicholas Piggin
2017-06-16 14:50 ` [PATCH v4 0/5] Improve watchdog config for arch watchdogs Don Zickus
2017-06-16 17:16 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616112407.e150c215209d86d7e8916a47@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=babu.moger@oracle.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome