From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbdFROXp (ORCPT ); Sun, 18 Jun 2017 10:23:45 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33582 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbdFROXk (ORCPT ); Sun, 18 Jun 2017 10:23:40 -0400 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, Masami Hiramatsu , Steven Rostedt , Frederic Weisbecker Subject: [PATCH 2/4] perf ftrace: Move setup_pager before opening trace_pipe Date: Sun, 18 Jun 2017 23:23:00 +0900 Message-Id: <20170618142302.25390-2-namhyung@kernel.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170618142302.25390-1-namhyung@kernel.org> References: <20170618142302.25390-1-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The perf ftrace fails to reset tracer after finish the recording like below: $ sudo perf ftrace -v hello write 'nop' to tracing/current_tracer failed: Device or resource busy ... This is because the trace_pipe file is open in pager process. Move the pager setup before opening the file. Cc: Steven Rostedt Cc: Frederic Weisbecker Fixes: 583359646fde ("perf ftrace: Use pager for displaying result") Signed-off-by: Namhyung Kim --- tools/perf/builtin-ftrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index 966a94fa8200..982b98ee639e 100644 --- a/tools/perf/builtin-ftrace.c +++ b/tools/perf/builtin-ftrace.c @@ -231,6 +231,8 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) goto out_reset; } + setup_pager(); + trace_file = get_tracing_file("trace_pipe"); if (!trace_file) { pr_err("failed to open trace_pipe\n"); @@ -254,8 +256,6 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) goto out_close_fd; } - setup_pager(); - perf_evlist__start_workload(ftrace->evlist); while (!done) { -- 2.13.0