From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751018AbdFSOvV (ORCPT ); Mon, 19 Jun 2017 10:51:21 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35921 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbdFSOvU (ORCPT ); Mon, 19 Jun 2017 10:51:20 -0400 Date: Mon, 19 Jun 2017 15:51:15 +0100 From: Lee Jones To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dtor@chromium.org, dianders@chromium.org Subject: Re: [PATCH v2] mfd: cros_ec: Free IRQ on exit Message-ID: <20170619145115.qzsbu3yej5obkta7@dell> References: <1497256966-29082-1-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1497256966-29082-1-git-send-email-jeffy.chen@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Jun 2017, Jeffy Chen wrote: > Currently we request the irq when probing, but never free it. So after > unbind ec driver, this irq will be left requested, which would break > the next bind: > [ 2683.338437] genirq: Flags mismatch irq 64. 00002008 (chromeos-ec) vs. 00002008 (chromeos-ec) > [ 2683.338591] cros-ec-spi spi5.0: request irq 64: error -16 > [ 2683.338610] cros-ec-spi spi5.0: cannot register EC > [ 2683.338656] cros-ec-spi: probe of spi5.0 failed with error -16 > > Signed-off-by: Jeffy Chen > > --- > > Changes in v2: > Improve the commit message. > > drivers/mfd/cros_ec.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index e31ac60..dc6ce90 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) > > cros_ec_acpi_remove_gpe_handler(); > > + if (ec_dev->irq) > + free_irq(ec_dev->irq, ec_dev); > + > return 0; > } > EXPORT_SYMBOL(cros_ec_remove); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog