From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com,
rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>
Subject: Re: [PATCH V3 06/12] kernfs: add exportfs operations
Date: Mon, 19 Jun 2017 15:07:33 -0400 [thread overview]
Message-ID: <20170619190733.GK12062@htj.duckdns.org> (raw)
In-Reply-To: <7051f2ab31a2e970efd64817f2a579634cc5b915.1497549993.git.shli@fb.com>
Hello,
On Thu, Jun 15, 2017 at 11:17:14AM -0700, Shaohua Li wrote:
> -static int kernfs_fill_super(struct super_block *sb, unsigned long magic)
> +static int kernfs_fill_super(struct super_block *sb, unsigned long magic,
> + bool enable_expop)
Hmm... can't we make this a KERNFS_ROOT_* flag?
> @@ -229,7 +287,8 @@ const void *kernfs_super_ns(struct super_block *sb)
> */
> struct dentry *kernfs_mount_ns(struct file_system_type *fs_type, int flags,
> struct kernfs_root *root, unsigned long magic,
> - bool *new_sb_created, const void *ns)
> + bool *new_sb_created, const void *ns,
> + bool enable_expop)
Ditto for other cases too.
> --- a/include/linux/kernfs.h
> +++ b/include/linux/kernfs.h
> @@ -97,6 +97,7 @@ struct kernfs_elem_attr {
>
> /* represent a kernfs node */
> struct kernfs_node_id {
> + /* the layout must match 'struct fid' */
> u32 ino;
> u32 generation;
> } __attribute__((packed));
Can we make it a union between struct fid and u64?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-06-19 19:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 18:17 [PATCH V3 00/12] blktrace: output cgroup info Shaohua Li
2017-06-15 18:17 ` [PATCH V3 01/12] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-06-19 18:52 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 02/12] kernfs: implement i_generation Shaohua Li
2017-06-19 18:52 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 03/12] kernfs: add an API to get kernfs node from inode number Shaohua Li
2017-06-19 18:59 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 04/12] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-06-19 19:00 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 05/12] kernfs: introduce kernfs_node_id Shaohua Li
2017-06-16 14:42 ` kbuild test robot
2017-06-19 19:01 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 06/12] kernfs: add exportfs operations Shaohua Li
2017-06-19 19:07 ` Tejun Heo [this message]
2017-06-15 18:17 ` [PATCH V3 07/12] cgroup: export fhandle info for a cgroup Shaohua Li
2017-06-15 18:17 ` [PATCH V3 08/12] blktrace: export cgroup info in trace Shaohua Li
2017-06-15 18:17 ` [PATCH V3 09/12] block: always attach cgroup info into bio Shaohua Li
2017-06-19 19:09 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 10/12] block: call __bio_free in bio_endio Shaohua Li
2017-06-15 18:17 ` [PATCH V3 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li
2017-06-19 19:14 ` Tejun Heo
2017-06-15 18:17 ` [PATCH V3 12/12] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619190733.GK12062@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome