From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbdFTI7m (ORCPT ); Tue, 20 Jun 2017 04:59:42 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:43171 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdFTI6A (ORCPT ); Tue, 20 Jun 2017 04:58:00 -0400 Date: Tue, 20 Jun 2017 10:57:48 +0200 From: Maxime Ripard To: Ziping Chen Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/3] ARM: dts: sunxi: add R_LRADC support for A83T Message-ID: <20170620085748.apv3wlehyllecb5q@flea.lan> References: <20170618130018.10684-1-techping.chan@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tinytkk5wdhgbroz" Content-Disposition: inline In-Reply-To: <20170618130018.10684-1-techping.chan@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tinytkk5wdhgbroz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 18, 2017 at 09:00:16PM +0800, Ziping Chen wrote: > From: Ziping Chen >=20 > The Allwinner A83T's R_LRADC is similiar with the > Allwinner A10's LRADC, they can use the same driver. There's a typo in similar above. > Add support for it. >=20 > Signed-off-by: Ziping Chen > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-= a83t.dtsi > index 8923ba625b76..ecc75bf6780e 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -301,5 +301,12 @@ > interrupt-controller; > #interrupt-cells =3D <3>; > }; > + > + r_lradc: lradc@01f03c00 { > + compatible =3D "allwinner,sun4i-a10-lradc-keys"; Could you add an A83T specific compatible here? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --tinytkk5wdhgbroz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZSOOMAAoJEBx+YmzsjxAg6ZEQAK5kJcJ2XKwhJQyzcNMuLd18 LOT93G+/PhORvBlg76VwYxnDSDolCSFb85IncMKhdo/GS1ep3jR/VozKdhSEbJ9+ 3NwX9XBPrGmjIbZHABFQvmMCevH/6VErad2sXLJQaw7AhumX0dkWrl/iHgNjzaMW /GcXwi0rxwx3k0U8D4fCDA/OfMKB48t7RdV4XECeveq1Ar5T4dooZfjkkyzQBWpK 5NCPgn59lwfGKOcJ3z9+wMiU0LSOY4gxc6P8VNSISZPg6DbxITT36WmJVBpooR3l fEJSZKIubMKOGbzFp/zKHykIVER+6Osbt/iVeaBoZF/DRb9PaQvhgh2Gxm+8Fs4C RcHMTxizyDEbIvjCLhPWqeEeC39UU2QkATJpynj+42HC0G3ZCGvMABEcpp4GBMsg Bn6xu5GTqfcldHMUt9csAi/NtJ/2fXuNxJLeMYh6YKVYkW1iuPhkp+7jwO13cpqP jGTr72AglQLqd7nGxjvtHUTTzECTs9DGnPq9fCnSxzxtIBXrojdv/JLBbUAi7yHJ wm1kRvhdGodz4PtW0ig0junTfvZdZsoOWG//XBqtv/697Pa7NzMPTsgBN3EIMhWZ LocdJOEbJ5uQB5QyrAn7k4mXMzo58tf101tY2Dj5eRC9INYBHS+8Il+82ZJLQFRa qJaVeYUD0kM4PmkbL/sw =DdQD -----END PGP SIGNATURE----- --tinytkk5wdhgbroz--