From: Dave Jones <davej@codemonkey.org.uk>
To: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>, Michal Hocko <mhocko@suse.com>
Subject: Re: Linux 4.12-rc6
Date: Tue, 20 Jun 2017 10:44:07 -0400 [thread overview]
Message-ID: <20170620144407.2wbyxrzmkwsz4mxe@codemonkey.org.uk> (raw)
In-Reply-To: <alpine.LSU.2.11.1706200152140.10925@eggly.anvils>
On Tue, Jun 20, 2017 at 02:05:53AM -0700, Hugh Dickins wrote:
> On Mon, 19 Jun 2017, Dave Jones wrote:
> >
> > I hacked up this harness to try and narrow it down more..
> >
> > #!/bin/bash
> >
> > . scripts/taint.sh
> >
> > while [ 1 ];
> > do
> > ./trinity -a64 -C1 -c mmap -N1 --enable-fds=testfile
> > check_tainted
> > done
>
> Very helpful reproducer, thank you Dave: I tried a couple of times,
> and it crashed in about 3 minutes each time. And good news is that
> the check that Linus suggested does indeed fix it. I'm anxious to
> send the patch in now, so have only tested about half an hour on
> x86_64 and half an hour x86_32 so far, just to make sure that at
> least there isn't something too embarrassing just around this first
> corner (some of the time with ulimit -s at default 8192, some of
> the time unlimited, since that affects layout decisions). I'll
> send in the patch now - many thanks for catching this so quickly.
Confirming that the patch seems to be doing the job for me too.
I'll leave it run for the morning, but initial results look good.
thanks,
Dave
next prev parent reply other threads:[~2017-06-20 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 15:04 Linus Torvalds
2017-06-20 0:26 ` Dave Jones
2017-06-20 2:32 ` Linus Torvalds
2017-06-20 2:52 ` Dave Jones
2017-06-20 3:12 ` Hugh Dickins
2017-06-20 3:42 ` Dave Jones
2017-06-20 9:05 ` Hugh Dickins
2017-06-20 14:44 ` Dave Jones [this message]
2017-06-20 9:11 ` Andy Whitcroft
2017-06-20 4:40 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620144407.2wbyxrzmkwsz4mxe@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®