From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbdFTUM1 (ORCPT ); Tue, 20 Jun 2017 16:12:27 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:65092 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdFTUMZ (ORCPT ); Tue, 20 Jun 2017 16:12:25 -0400 From: Arnd Bergmann To: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Cc: Arnd Bergmann , Ivan Delalande , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [net-next PATCH] tcp: md5: hide unused variable Date: Tue, 20 Jun 2017 22:11:21 +0200 Message-Id: <20170620201203.121119-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:gfZ5o8RcuXAkMU8xEDt9OyluxspsuwsK0bEEsIttnwSq6NjVjLl 3BugwaDzSNkZuKBJ7lZ8v0x7fuomYxtEG/W8/qU/P1dQ4bWpUFBwy8H1qpVVEFoR2vkouqB /1F4syB/fUpj2zAeSxbW5wnYsWGPaRQN44Oc+xv4uF75XwuPG7Cy7lW1z9uAFyx1LsZv7yZ iY/F/R8lL+TBHmeJtRIUw== X-UI-Out-Filterresults: notjunk:1;V01:K0:1VO/atqaerk=:aAziWxuDCwWjaBqxYPyuXr YSo1zzBzj60Mg3vb98C1//otjXJs5RTMUvJd55VpWHeLt2kfbQA42A5v1gSswf7+lrtmfuuD3 Cga0zTplKI6tRzow2ptAsotaDRty4o2gkTjQkmHeAZIMTU2tU82FoOZYda6jPnZdyT8SasN/b JPNJgpJK/l0ptmFVkK3WLwkYRsCYfJr3Bzn6g1mdP8nTja3e82ON0H/jSwLoqA8A17/D32h39 QxwWe8vqxX+uFs09GfON0m041lgCWpL45DFkl9m8CKisS6Uf8UAfUt0qSNV/yFjzFn6ibcRTJ rym9FCiAqETmNIBKg4JRehFPAOEKUjR4LqAbj5zJR7a2M/IUEl5Lbr3HmdfCFEdlViWcbPrMh bIqGLgrqsXl4LJ6A2X29tBERXzznPtJlMXDn37oaQhEXMglLEQnt6G92fDRbCbtis9SFvKs8c nJrAuGQJInA1BFO97RZ9aBzvqUEIILZKT3PP9WvX/rF4+OKzLODz6wYF3Nd+UPisol+ttP2nq tIysMhv1VV7c4dqy7B5pejqOIYLmeVQCQV1/2MLDLgZJ6unNJn6HdtSa3SMQ1VP+N8Nw5vHYF BV6n1Ds5Y/g1t8usL9k9jMiEcJVE/dv64OVh6f3bKUMHjqgDho6PLxlwPpyIYYEcoZhj5vkVy P5kMNzNqMil91PXgTBWBtgBzquuFnC7LgJfoKVE/7BN+cB13Na/9aIysg5EQWgGGcblI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changing from a memcpy to per-member comparison left the size variable unused: net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup': net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable] This does not show up when CONFIG_IPV6 is enabled, but the variable can be removed either way, along with the now unused assignment. Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup") Signed-off-by: Arnd Bergmann --- net/ipv4/tcp_ipv4.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index bf407f3e20dd..e20bcf0061af 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -907,7 +907,6 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk, { const struct tcp_sock *tp = tcp_sk(sk); struct tcp_md5sig_key *key; - unsigned int size = sizeof(struct in_addr); const struct tcp_md5sig_info *md5sig; __be32 mask; struct tcp_md5sig_key *best_match = NULL; @@ -918,10 +917,7 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk, lockdep_sock_is_held(sk)); if (!md5sig) return NULL; -#if IS_ENABLED(CONFIG_IPV6) - if (family == AF_INET6) - size = sizeof(struct in6_addr); -#endif + hlist_for_each_entry_rcu(key, &md5sig->head, node) { if (key->family != family) continue; -- 2.9.0