From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbdFTUlm (ORCPT ); Tue, 20 Jun 2017 16:41:42 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34780 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbdFTUlk (ORCPT ); Tue, 20 Jun 2017 16:41:40 -0400 Date: Tue, 20 Jun 2017 21:41:22 +0100 From: Sudip Mukherjee To: Dan Carpenter Cc: Andy Shevchenko , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Message-ID: <20170620204122.GA5603@sudip-laptop> References: <1497904378-4808-1-git-send-email-sudipm.mukherjee@gmail.com> <20170620200858.GA5287@sudip-laptop> <20170620202055.zhleonjxyzzrl5d3@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620202055.zhleonjxyzzrl5d3@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Tue, Jun 20, 2017 at 11:20:55PM +0300, Dan Carpenter wrote: > That's totally bogus. Just say you don't know. It's never a > reguirement that people fix AMD drivers before they can review code... Yes, I don't know how drm drivers work, so I blindly follow what has been done there. And since sm750 ultimately has to be converted to a drm driver to be taken out of staging, so I will prefer to have similar changes here. -- Regards Sudip