From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752551AbdFTU5t (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 16:57:49 -0400
Received: from mx2.suse.de ([195.135.220.15]:35853 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751076AbdFTU5s (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 16:57:48 -0400
Date: Tue, 20 Jun 2017 22:57:46 +0200
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, jeyu@redhat.com
Subject: Re: [PATCH v2] fs: warn in case userspace lied about modprobe return
Message-ID: <20170620205746.GY21846@wotan.suse.de>
References: <lkml.kernel.org/r/20170601180347.GL8951@wotan.suse.de>
 <20170601180801.19827-1-mcgrof@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170601180801.19827-1-mcgrof@kernel.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 01, 2017 at 11:08:01AM -0700, Luis R. Rodriguez wrote:
> kmod <= v19 was broken -- it could return 0 to modprobe calls,
> incorrectly assuming that a kernel module was built-in, whereas in
> reality the module was just forming in the kernel. The reason for this
> is an incorrect userspace heuristics. A userspace kmod fix is available
> for it [0], however should userspace break again we could go on with
> an failed get_fs_type() which is hard to debug as the request_module()
> is detected as returning 0. The first suspect would be that there is
> something worth with the kernel's module loader and obviously in this
> case that is not the issue.
> 
> Since these issues are painful to debug complain when we know userspace
> has outright lied to us.
> 
> [0] http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/libkmod/libkmod-module.c?id=fd44a98ae2eb5eb32161088954ab21e58e19dfc4
> 
> Suggested-by: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Jessica Yu <jeyu@redhat.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

*poke* Al?

  Luis