From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbdFTVlC (ORCPT ); Tue, 20 Jun 2017 17:41:02 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57690 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdFTVlB (ORCPT ); Tue, 20 Jun 2017 17:41:01 -0400 Date: Tue, 20 Jun 2017 23:40:58 +0200 From: Andrew Lunn To: Zach Brown Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround Message-ID: <20170620214058.GE12383@lunn.ch> References: <1497980891-10495-1-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497980891-10495-1-git-send-email-zach.brown@ni.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 12:48:11PM -0500, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll. However if the phy uses only > intterupts, the phy will stall, since interrupts are off. This patch > fixes the issue by calling config_intr after resetting the phy. > > Fixes: d2fd719bcb0e ("net/phy: micrel: Add workaround for bad autoneg ") > Signed-off-by: Zach Brown Reviewed-by: Andrew Lunn Andrew