From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbdFTVlm (ORCPT ); Tue, 20 Jun 2017 17:41:42 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36406 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbdFTVlj (ORCPT ); Tue, 20 Jun 2017 17:41:39 -0400 Date: Tue, 20 Jun 2017 22:41:25 +0100 From: Sudip Mukherjee To: Bartlomiej Zolnierkiewicz Cc: Christophe JAILLET , khoroshilov@ispras.ru, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] sm501fb: Silence a coccinelle script warning. Message-ID: <20170620214125.GA5843@sudip-laptop> References: <20170508061116.31471-1-christophe.jaillet@wanadoo.fr> <3551083.sIQ6JeN0q9@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3551083.sIQ6JeN0q9@amdc3058> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartlomiej, On Wed, Jun 14, 2017 at 12:54:58PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, May 08, 2017 08:11:16 AM Christophe JAILLET wrote: > > According to surrounding goto, it is likely that 'goto err_probed_panel' is > > expected here. > > This change is just done in order to silence some coccinelle scripts > > which try to detect wrongly ordered goto. > > > > If 'info->fb[HEAD_PANEL]' and' 'info->fb[HEAD_CRT]' are both NULL, this > > means that no 'framebuffer_alloc' has been performed, so 'goto err_alloc' > > looks fine. > > Anyway, it is also harmless in this case to call 'framebuffer_release'. > > The code looks more straight forward. > > > > Signed-off-by: Christophe JAILLET > > It seems that the code for supporting only selected framebuffers > (only HEAD_PANEL fb or only HEAD_CRT fb) is broken anyway as at least > the suspend/resume support assumes that both framebuffers are always > present. Also all sm501fb driver users always try try to initialize > both framebuffers. Therefore I would prefer the removal of non-working > individual framebuffers support (the code that your patch modifies > would be removed as well). Could you please look into it? Looks like it will be easier to fix the suspend/resume functions and the part of probe which creates the device files for both. Let me have a look and I will try to send you a patch over the weekend. -- Regards Sudip