From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752910AbdFUQfu (ORCPT ); Wed, 21 Jun 2017 12:35:50 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:40832 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbdFUQft (ORCPT ); Wed, 21 Jun 2017 12:35:49 -0400 Date: Wed, 21 Jun 2017 11:20:00 -0400 (EDT) Message-Id: <20170621.112000.1689554856831469695.davem@davemloft.net> To: arnd@arndb.de Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, colona@arista.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH] tcp: md5: hide unused variable From: David Miller In-Reply-To: <20170620201203.121119-1-arnd@arndb.de> References: <20170620201203.121119-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Jun 2017 07:38:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 20 Jun 2017 22:11:21 +0200 > Changing from a memcpy to per-member comparison left the > size variable unused: > > net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup': > net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable] > > This does not show up when CONFIG_IPV6 is enabled, but the > variable can be removed either way, along with the now unused > assignment. > > Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup") > Signed-off-by: Arnd Bergmann Applied, thanks.