From: Daniel Vetter <daniel@ffwll.ch>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"Philippe Cornu" <philippe.cornu@st.com>,
"Christian König" <christian.koenig@amd.com>,
"Yannick Fertre" <yannick.fertre@st.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Dave Airlie" <airlied@redhat.com>,
virtualization@lists.linux-foundation.org,
"Vincent Abriou" <vincent.abriou@st.com>,
"Ben Skeggs" <bskeggs@redhat.com>
Subject: Re: [PATCH 00/11] improve the fb_setcmap helper
Date: Wed, 21 Jun 2017 09:40:17 +0200 [thread overview]
Message-ID: <20170621074017.owckvjsejf63wpju@phenom.ffwll.local> (raw)
In-Reply-To: <1497986735-14418-1-git-send-email-peda@axentia.se>
On Tue, Jun 20, 2017 at 09:25:24PM +0200, Peter Rosin wrote:
> Hi!
>
> While trying to get CLUT support for the atmel_hlcdc driver, and
> specifically for the emulated fbdev interface, I received some
> push-back that my feeble in-driver attempts should be solved
> by the core. This is my attempt to do it right.
>
> Boris and Daniel, was this approximately what you had in mind?
Yeah, this is awesome. I tried to do it a few times myself, but always
failed (also due to lack of real use-case on my side).
> I have obviously not tested all of this with more than a compile,
> but the first patch is enough to make the atmel-hlcdc driver
> do what I need. The rest is just lots of removals and cleanup
> made possible by the improved core.
If it works for you it's imo good enough. Not sure anyone else really
cares about fbdev lut support at all. I have a few comments on the first
patch, but once that's sorted, and once we have given driver maintainers
enough time to ack I think I'll merge the entire pile into drm-misc.
Nice work, thanks for doing it.
Cheers, Daniel
> Please test, I would not be surprised if I have fouled up some
> bit-manipulation somewhere in this mostly mechanical change...
>
> Cheers,
> peda
>
> Peter Rosin (11):
> drm/fb-helper: do a generic fb_setcmap helper in terms of crtc
> .gamma_set
> drm: amd: remove dead code and pointless local lut storage
> drm: ast: remove dead code and pointless local lut storage
> drm: cirrus: remove dead code and pointless local lut storage
> dmr: gma500: remove dead code and pointless local lut storage
> drm: i915: remove dead code and pointless local lut storage
> drm: mgag200: remove dead code and pointless local lut storage
> drm: nouveau: remove dead code and pointless local lut storage
> drm: radeon: remove dead code and pointless local lut storage
> drm: stm: remove dead code and pointless local lut storage
> drm: remove unused and redundant callbacks
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 24 -----
> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 27 ++----
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 27 ++----
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 27 ++----
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 27 ++----
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 23 -----
> drivers/gpu/drm/ast/ast_drv.h | 1 -
> drivers/gpu/drm/ast/ast_fb.c | 20 -----
> drivers/gpu/drm/ast/ast_mode.c | 26 ++----
> drivers/gpu/drm/cirrus/cirrus_drv.h | 8 --
> drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 -
> drivers/gpu/drm/cirrus/cirrus_mode.c | 71 ++++-----------
> drivers/gpu/drm/drm_fb_helper.c | 131 +++++++++-------------------
> drivers/gpu/drm/gma500/framebuffer.c | 22 -----
> drivers/gpu/drm/gma500/gma_display.c | 32 +++----
> drivers/gpu/drm/gma500/psb_intel_display.c | 7 +-
> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
> drivers/gpu/drm/i915/intel_drv.h | 1 -
> drivers/gpu/drm/i915/intel_fbdev.c | 31 -------
> drivers/gpu/drm/mgag200/mgag200_drv.h | 5 --
> drivers/gpu/drm/mgag200/mgag200_fb.c | 2 -
> drivers/gpu/drm/mgag200/mgag200_mode.c | 62 ++++---------
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 26 ++----
> drivers/gpu/drm/nouveau/nouveau_crtc.h | 3 -
> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 22 -----
> drivers/gpu/drm/nouveau/nv50_display.c | 39 +++------
> drivers/gpu/drm/radeon/atombios_crtc.c | 1 -
> drivers/gpu/drm/radeon/radeon_connectors.c | 7 +-
> drivers/gpu/drm/radeon/radeon_display.c | 71 ++++++---------
> drivers/gpu/drm/radeon/radeon_fb.c | 2 -
> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 1 -
> drivers/gpu/drm/stm/ltdc.c | 12 ---
> drivers/gpu/drm/stm/ltdc.h | 1 -
> include/drm/drm_fb_helper.h | 32 -------
> include/drm/drm_modeset_helper_vtables.h | 16 ----
> 36 files changed, 171 insertions(+), 640 deletions(-)
>
> --
> 2.1.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2017-06-21 7:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 19:25 Peter Rosin
2017-06-20 19:25 ` [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set Peter Rosin
2017-06-21 7:38 ` Daniel Vetter
2017-06-21 7:59 ` Michel Dänzer
2017-06-21 8:14 ` [Nouveau] " Daniel Vetter
2017-06-21 8:36 ` Michel Dänzer
2017-06-21 9:40 ` Peter Rosin
2017-06-22 6:36 ` Daniel Vetter
2017-06-22 8:48 ` Peter Rosin
2017-06-23 8:40 ` Daniel Vetter
2017-06-20 19:25 ` [PATCH 02/11] drm: amd: remove dead code and pointless local lut storage Peter Rosin
2017-06-20 19:25 ` [PATCH 03/11] drm: ast: " Peter Rosin
2017-06-20 19:25 ` [PATCH 04/11] drm: cirrus: " Peter Rosin
2017-06-20 19:25 ` [PATCH 05/11] dmr: gma500: " Peter Rosin
2017-06-20 19:25 ` [PATCH 06/11] drm: i915: " Peter Rosin
2017-06-20 19:25 ` [PATCH 07/11] drm: mgag200: " Peter Rosin
2017-06-20 19:25 ` [PATCH 08/11] drm: nouveau: " Peter Rosin
2017-06-21 10:35 ` Peter Rosin
2017-06-20 19:25 ` [PATCH 09/11] drm: radeon: " Peter Rosin
2017-06-20 19:25 ` [PATCH 10/11] drm: stm: " Peter Rosin
2017-06-20 19:25 ` [PATCH 11/11] drm: remove unused and redundant callbacks Peter Rosin
2017-06-21 16:34 ` kbuild test robot
2017-06-22 6:37 ` Daniel Vetter
2017-06-22 7:13 ` Boris Brezillon
2017-06-21 7:40 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621074017.owckvjsejf63wpju@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=peda@axentia.se \
--cc=philippe.cornu@st.com \
--cc=vincent.abriou@st.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®