From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbdFUOfb (ORCPT ); Wed, 21 Jun 2017 10:35:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49192 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613AbdFUOf3 (ORCPT ); Wed, 21 Jun 2017 10:35:29 -0400 Date: Wed, 21 Jun 2017 22:35:08 +0800 From: Greg KH To: Dhananjay Balan Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: move common locking code to a macro Message-ID: <20170621143508.GB14790@kroah.com> References: <20170620165013.11013-1-mail@dbalan.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620165013.11013-1-mail@dbalan.in> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote: > The locking and unlocking code used by copy routines is common, so > moved it to a macro. Ick, no, never "hide" locks like this, that's not good at all. We want to see the locks in the code where it happens, otherwise it is not obvious as to what is going on. sorry, greg k-h