From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbdFUWHw (ORCPT ); Wed, 21 Jun 2017 18:07:52 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:57834 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbdFUWHu (ORCPT ); Wed, 21 Jun 2017 18:07:50 -0400 From: Arnd Bergmann To: Florian Fainelli Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Kishon Vijay Abraham I , Andrew Lunn , netdev@vger.kernel.org, "David S . Miller" , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [RFC 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Date: Thu, 22 Jun 2017 00:06:07 +0200 Message-Id: <20170621220626.46691-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170621220626.46691-1-arnd@arndb.de> References: <20170621220626.46691-1-arnd@arndb.de> X-Provags-ID: V03:K0:sGozzXOWYl2thooS4xjQoRQW9gcQB+E+H0Uyjyz6+QmN7ZG/oj4 UnQCHJaVK2n5SXwQp7bw0FU79lsSWubi4zmXENPieGfa8RiFO7x94WN8+jvML9IxYL7FK84 Tragki22rHmjyAKRn253jGJkiX3euXEtx86ZVuL4s+tt2FiaZZLVwoej1YyPRM+Ru3vgAYz yecYfSooZlK3Q1rucnSOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ss5uy2t86cc=:r7vHrVdhps4UB/OqoNOFMQ R96Z66Og2EdFy1P3yxd9Vb4GJVDJrLdRwk0lNo9Y5pdRihe3rcV5Ezp3LEmBaoSrGHk/5/GKI IuB/qDglGFgEqZHMwCPkf7V+HKVOB7zhiUgHqZNmCVY7Ak0YEPbM+5GIlk0NlmAtOGsg92ICV eUURquqJwdTcyueSE1d6js3+Lxof4osJS42L3RTDIhNhAh3S5CK3qMxmLYHbVkGHRroLg75Zo GMcMd4OmiacknMOzK1LdRufy7di6MMm95dW76D7tZ2tXu1oEFLgtLGjJI4NyJgR+kwvvzIUP3 lH+d7/Nwed6XS6OQXddlAaHK0Qcc7Dhh9tdzplYPZx7LFSknQYF8v+iq1AvMjPzrZFxnS2mAn pm7nDJjnsfeOmWftRFjK0fRgw7PRPo0f1fhnlJjpfnC8w5lCoX4LTryyQNAt4ObcH+v+oaiSH DLCZ6rLz8g+21FvBIMlXcp9HDPBsEBDE8jkd0IwYChozWrOTfuTea0pyAsOJSSF2NGAXm21JY jR/osdllS0DQJlrNYTmNKmASOJQo3i7xEJuWfHW/dmT5YER6ra3xM7hGcTvWZuhJ8irwsRtiD HDkPEHNJRY7B25n+31gdQJEygfU16p3ToE0QilwtY52Fm3q2wW+8HrZ57DVN1ZP44oKwcLrLa ZcIjgCZV8B8ZsbiVFx+H4effzdATKJzbPYTRMvFIn29taKXxtfkzsz1ADwWbG2LZkslc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit': phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init': phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register' phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister' Using 'depends on MDIO_BUS' instead will avoid the link error. Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") Signed-off-by: Arnd Bergmann --- drivers/phy/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 tristate "Broadcom Northstar USB 3.0 PHY Driver" depends on ARCH_BCM_IPROC || COMPILE_TEST depends on HAS_IOMEM && OF + depends on MDIO_BUS select GENERIC_PHY - select MDIO_DEVICE help Enable this to support Broadcom USB 3.0 PHY connected to the USB controller on Northstar family. -- 2.9.0