From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbdFVPHT (ORCPT ); Thu, 22 Jun 2017 11:07:19 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35712 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbdFVPHQ (ORCPT ); Thu, 22 Jun 2017 11:07:16 -0400 Date: Thu, 22 Jun 2017 11:07:14 -0400 (EDT) Message-Id: <20170622.110714.778230283978724620.davem@davemloft.net> To: zach.brown@ni.com Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround From: David Miller In-Reply-To: <1497980891-10495-1-git-send-email-zach.brown@ni.com> References: <1497980891-10495-1-git-send-email-zach.brown@ni.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Jun 2017 07:25:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zach Brown Date: Tue, 20 Jun 2017 12:48:11 -0500 > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll. However if the phy uses only > intterupts, the phy will stall, since interrupts are off. This patch > fixes the issue by calling config_intr after resetting the phy. > > Fixes: d2fd719bcb0e ("net/phy: micrel: Add workaround for bad autoneg ") > Signed-off-by: Zach Brown Applied and queued up for -stable.