From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbdFVBlG (ORCPT ); Wed, 21 Jun 2017 21:41:06 -0400 Received: from imap.thunk.org ([74.207.234.97]:57546 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbdFVBlD (ORCPT ); Wed, 21 Jun 2017 21:41:03 -0400 Date: Wed, 21 Jun 2017 21:40:40 -0400 From: "Theodore Ts'o" To: Tahsin Erdogan Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/32] ext4: fix ref counting for ea_inode Message-ID: <20170622014040.bse3rxjn3cnrxifh@thunk.org> Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170621212142.16581-1-tahsin@google.com> <20170621212142.16581-8-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621212142.16581-8-tahsin@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 02:21:18PM -0700, Tahsin Erdogan wrote: > The ref count on ea_inode is incremented by > ext4_xattr_inode_orphan_add() which is supposed to be decremented by > ext4_xattr_inode_array_free(). The decrement is conditioned on whether > the ea_inode is currently on the orphan list. However, the orphan list > addition only happens when journaling is enabled. In non-journaled case,r > we fail to release the ref count causing an error message like below. > > "VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds. > Have a nice day..." > > Signed-off-by: Tahsin Erdogan Thanks, applied. - Ted