From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdFVB6k (ORCPT ); Wed, 21 Jun 2017 21:58:40 -0400 Received: from imap.thunk.org ([74.207.234.97]:57792 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdFVB6i (ORCPT ); Wed, 21 Jun 2017 21:58:38 -0400 Date: Wed, 21 Jun 2017 21:58:30 -0400 From: "Theodore Ts'o" To: Tahsin Erdogan Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/32] ext4: clean up ext4_xattr_inode_get() Message-ID: <20170622015830.x26e5pbmmjj7tmzy@thunk.org> Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170621212142.16581-1-tahsin@google.com> <20170621212142.16581-11-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621212142.16581-11-tahsin@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 02:21:21PM -0700, Tahsin Erdogan wrote: > The input and output values of *size parameter are equal on successful > return from ext4_xattr_inode_get(). On error return, the callers ignore > the output value so there is no need to update it. > > Also check for NULL return from ext4_bread(). If the actual xattr inode > size happens to be smaller than the expected size, ext4_bread() may > return NULL which would indicate data corruption. > > Signed-off-by: Tahsin Erdogan Thanks, applied. - Ted