From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbdFVHjo (ORCPT ); Thu, 22 Jun 2017 03:39:44 -0400 Received: from mga06.intel.com ([134.134.136.31]:25113 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdFVHjm (ORCPT ); Thu, 22 Jun 2017 03:39:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,372,1493708400"; d="scan'208";a="1163359167" Date: Thu, 22 Jun 2017 10:39:37 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linux PM , LKML , Linux PCI , Linux ACPI , Bjorn Helgaas , Greg Kroah-Hartman Subject: Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code Message-ID: <20170622073937.GR629@lahna.fi.intel.com> References: <12296383.UdE5HVtyng@aspire.rjw.lan> <4424061.UyS4hGnq0F@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4424061.UyS4hGnq0F@aspire.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2017 at 11:33:52PM +0200, Rafael J. Wysocki wrote: > -#ifdef CONFIG_PM_SLEEP > -/** > - * acpi_pm_device_sleep_wake - Enable or disable device to wake up the system. > - * @dev: Device to enable/desible to wake up the system from sleep states. > - * @enable: Whether to enable or disable @dev to wake up the system. > - */ > -int acpi_pm_device_sleep_wake(struct device *dev, bool enable) > +int acpi_pm_device_wakeup(struct device *dev, bool enable) Can we call it acpi_pm_device_enable_wakeup() and then provide corresponding acpi_pm_device_disable_wakeup()? I find those easier to understand than acpi_pm_device_wakeup() that sounds like the device should be woken up now.