From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753001AbdFVItF (ORCPT ); Thu, 22 Jun 2017 04:49:05 -0400 Received: from mail.skyhub.de ([5.9.137.197]:45606 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbdFVItD (ORCPT ); Thu, 22 Jun 2017 04:49:03 -0400 Date: Thu, 22 Jun 2017 10:48:44 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/mce: Always save severity in machine_check_poll Message-ID: <20170622084828.ojspq6zg7ee3ppfi@pd.tnic> References: <1498074402-98633-1-git-send-email-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1498074402-98633-1-git-send-email-Yazen.Ghannam@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 02:46:42PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > The severity gives a hint as to how to handle the error. The notifier > blocks can then use the severity to decide on an action. It's not necessary > for machine_check_poll() to filter errors for the notifier chain, since > each block will check its own set of conditions before handling an error. > Also, there isn't any urgency for machine_check_poll() to make decisions > based on severity like in do_machine_check(). > > If we can assume that a severity is set then we can use them in more > notifier blocks. For example, the CEC block can check for a "KEEP" severity Hmm, I'm not sure about this. If we did this, we would have to *make* CECCs be always KEEP severity. And they are now but doing that would make that mapping CECC->KEEP imprecise and unnecessary but required.... Yeah, we can talk about that when we have to cross that bridge. So I've left the example but made the above s/can/could/ :) > rather than checking bits in the status. This isn't possible now since the > severity is not set except for "DEFFRRED/UCNA" errors with a valid address. > > Save the severity since we have it, and let the notifier blocks decide if > they want to do anything. > > Signed-off-by: Yazen Ghannam > --- > Link: > https://lkml.kernel.org/r/1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com > > v1->v2: > * Expand commit message. > > arch/x86/kernel/cpu/mcheck/mce.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.