From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753061AbdFVI7B (ORCPT ); Thu, 22 Jun 2017 04:59:01 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34064 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776AbdFVI66 (ORCPT ); Thu, 22 Jun 2017 04:58:58 -0400 Date: Thu, 22 Jun 2017 10:58:48 +0200 From: Ingo Molnar To: Matthias Kaehlcke Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , "H . J . Lu" , David Woodhouse , Masahiro Yamada , Michal Marek , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Davidson , Greg Hackmann , Nick Desaulniers , Stephen Hines , Kees Cook , Arnd Bergmann , Bernhard.Rosenkranzer@linaro.org, Peter Foley , Behan Webster , Douglas Anderson Subject: Re: [PATCH v5 0/3] x86: stack alignment for boot code and clang Message-ID: <20170622085848.kot52wfxsntruoaz@gmail.com> References: <20170621232805.149448-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621232805.149448-1-mka@chromium.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matthias Kaehlcke wrote: > This series fixes an issue with the stack of the x86 boot code not > being aligned as intended. Further it adapts the Makefile to account > for the fact that clang uses a different option to configure the > stack alignment than gcc (-mstack-alignment=N vs > -mpreferred-stack-boundary=N) > > Collaterally the series adds the new kbuild macro __cc-option and > refactors the macros cc-option and hostcc-option to make use of > __cc-option. > > Matthias Kaehlcke (3): > kbuild: Add __cc-option macro > x86/build: Use __cc-option for boot code compiler options > x86/build: Specify stack alignment for clang > > Makefile | 2 +- > arch/x86/Makefile | 33 +++++++++++++++++++++++++-------- > scripts/Kbuild.include | 14 ++++++++++++-- > scripts/Makefile.host | 6 ------ > 4 files changed, 38 insertions(+), 17 deletions(-) So given that there are non-trivial kbuild changes here, I'd suggest these patches might have a better home in the kbuild tree. For the x86 bits: Acked-by: Ingo Molnar Thanks, Ingo