mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
	"Luis Claudio R . Goncalves" <lgoncalv@redhat.com>,
	Clark Williams <williams@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate
Date: Thu, 22 Jun 2017 11:29:34 +0200	[thread overview]
Message-ID: <20170622092934.jokgiprvf5m7krdi@gmail.com> (raw)
In-Reply-To: <9d7f19113ac410735707e0f179853100e9918c0d.1498068819.git.bristot@redhat.com>


* Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

> Add the value of the rt_rq.rt_nr_migratory and dl_rq.dl_nr_migratory
> to the sched_debug output, for instance:
> 
> rt_rq[0]:
>   .rt_nr_running                 : 2
>   .rt_nr_migratory               : 1     <--- Like this
>   .rt_throttled                  : 0
>   .rt_time                       : 828.645877
>   .rt_runtime                    : 1000.000000
> 
> This is useful to debug problems related to the dl/rt schedulers.
> 
> This also fixes the format of some variables, that were unsigned, rather
> than signed.
> 
> [ I am sending this patch to be able to demonstrate       ]
> [ the problem in the kernel-rt, however, this patch can   ]
> [ be merged in the vanilla kernel, if people decide it    ]
> [ is worth having it.                                     ]

Note that this patch breaks in various cross-builds - here's the Alpha defconfig 
build:

/home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
/home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no member 
named 'rt_nr_migratory'
  SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
                                                            ^
/home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
'SEQ_printf'
   seq_printf(m, x);  \
...

Thanks,

	Ingo

  reply	other threads:[~2017-06-22  9:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 19:28 [PATCH 0/2] rt: Increase/decrease the nr of migratory tasks when enabling/disabling migration Daniel Bristot de Oliveira
2017-06-21 19:29 ` [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate Daniel Bristot de Oliveira
2017-06-22  9:29   ` Ingo Molnar [this message]
2017-06-22 13:02     ` Daniel Bristot de Oliveira
2017-06-21 19:29 ` [PATCH 2/2] rt: Increase/decrease the nr of migratory tasks when enabling/disabling migration Daniel Bristot de Oliveira
2017-06-22  8:38   ` Ingo Molnar
2017-06-22 13:31     ` Daniel Bristot de Oliveira
2017-06-22 19:49       ` Ingo Molnar
2017-06-23 13:36         ` Daniel Bristot de Oliveira
2017-06-24  6:41           ` Ingo Molnar
2017-06-26 12:16             ` Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622092934.jokgiprvf5m7krdi@gmail.com \
    --to=mingo@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bristot@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®