From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbdFVO2L (ORCPT ); Thu, 22 Jun 2017 10:28:11 -0400 Received: from imap.thunk.org ([74.207.234.97]:60166 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbdFVO2J (ORCPT ); Thu, 22 Jun 2017 10:28:09 -0400 Date: Thu, 22 Jun 2017 10:28:04 -0400 From: "Theodore Ts'o" To: Tahsin Erdogan Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 21/32] ext4: modify ext4_xattr_ino_array to hold struct inode * Message-ID: <20170622142804.trfy3ce6wibh5amx@thunk.org> Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170621212142.16581-1-tahsin@google.com> <20170621212142.16581-21-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621212142.16581-21-tahsin@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 02:21:31PM -0700, Tahsin Erdogan wrote: > Tracking struct inode * rather than the inode number eliminates the > repeated ext4_xattr_inode_iget() call later. The second call cannot > fail in practice but still requires explanation when it wants to ignore > the return value. Avoid the trouble and make things simple. > > Signed-off-by: Tahsin Erdogan Added to the ext4 patch queue, thanks. - Ted