From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdFVPji (ORCPT ); Thu, 22 Jun 2017 11:39:38 -0400 Received: from imap.thunk.org ([74.207.234.97]:60542 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdFVPjh (ORCPT ); Thu, 22 Jun 2017 11:39:37 -0400 Date: Thu, 22 Jun 2017 11:39:33 -0400 From: "Theodore Ts'o" To: Tahsin Erdogan Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 25/32] ext4: add ext4_is_quota_file() Message-ID: <20170622153933.gjc4ni47spchlix6@thunk.org> Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170622014939.3592-1-tahsin@google.com> <20170622014939.3592-2-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622014939.3592-2-tahsin@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 06:49:32PM -0700, Tahsin Erdogan wrote: > IS_NOQUOTA() indicates whether quota is disabled for an inode. Ext4 > also uses it to check whether an inode is for a quota file. The > distinction currently doesn't matter because quota is disabled only > for the quota files. When we start disabling quota for other inodes > in the future, we will want to make the distinction clear. > > Replace IS_NOQUOTA() call with ext4_is_quota_file() at places where > we are checking for quota files. > > Signed-off-by: Tahsin Erdogan Added to the ext4 patch queue, thanks. - Ted