From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbdFVPy2 (ORCPT ); Thu, 22 Jun 2017 11:54:28 -0400 Received: from imap.thunk.org ([74.207.234.97]:60702 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbdFVPy1 (ORCPT ); Thu, 22 Jun 2017 11:54:27 -0400 Date: Thu, 22 Jun 2017 11:54:24 -0400 From: "Theodore Ts'o" To: Tahsin Erdogan Cc: Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 31/32] ext4: strong binding of xattr inode references Message-ID: <20170622155424.jj6c3fglp3vehddq@thunk.org> Mail-Followup-To: Theodore Ts'o , Tahsin Erdogan , Andreas Dilger , "Darrick J . Wong" , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170622014939.3592-1-tahsin@google.com> <20170622014939.3592-8-tahsin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622014939.3592-8-tahsin@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 06:49:38PM -0700, Tahsin Erdogan wrote: > To verify that a xattr entry is not pointing to the wrong xattr inode, > we currently check that the target inode has EXT4_EA_INODE_FL flag set and > also the entry size matches the target inode size. > > For stronger validation, also incorporate crc32c hash of the value into > the e_hash field. This is done regardless of whether the entry lives in > the inode body or external attribute block. > > Signed-off-by: Tahsin Erdogan Added to the ext4 patch queue, thanks. - Ted