From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbdFWFud (ORCPT ); Fri, 23 Jun 2017 01:50:33 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:44266 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754394AbdFWFsd (ORCPT ); Fri, 23 Jun 2017 01:48:33 -0400 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, Masami Hiramatsu , Andi Kleen , Adrian Hunter , Wang Nan Subject: [PATCH/RFC 4/9] perf symbols: Load kernel module symbols ASAP Date: Fri, 23 Jun 2017 14:48:22 +0900 Message-Id: <20170623054827.3828-5-namhyung@kernel.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623054827.3828-1-namhyung@kernel.org> References: <20170623054827.3828-1-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When loading kernel symbols from /proc/kallsyms, it might have different addresses for modules. We should honor the mmap event recorded in a perf.data so load the module symbols when it sees the event so that it cannot be overridden by symbols in /proc/kallsyms later. Cc: Adrian Hunter Cc: Wang Nan Signed-off-by: Namhyung Kim --- tools/perf/util/machine.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index d838f893e639..799efe920f0c 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -656,6 +656,9 @@ struct map *machine__findnew_module_map(struct machine *machine, u64 start, map_groups__insert(&machine->kmaps, map); + if (dso->has_build_id) + map__load(map); + /* Put the map here because map_groups__insert alread got it */ map__put(map); out: -- 2.13.1