From: Yadan Fan <ydfan@suse.com>
To: don.brace@microsemi.com, martin.petersen@oracle.com,
jejb@linux.vnet.ibm.com
Cc: esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Yadan Fan <ydfan@suse.com>
Subject: [PATCH v2 2/2] smartpqi: limit transfer length to 1MB
Date: Fri, 23 Jun 2017 17:40:06 +0800 [thread overview]
Message-ID: <20170623094006.16807-2-ydfan@suse.com> (raw)
In-Reply-To: <20170623094006.16807-1-ydfan@suse.com>
The smartpqi firmware will bypass the cache for any request larger
than 1MB, so we should cap the request size to avoid any
performance degradation in kernels later than v4.3
This degradation is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
which changed max_sectors_kb to 1280k, but the hardware is able to
work fine with it, so the true fix should be from smartpqi driver.
Signed-off-by: Yadan Fan <ydfan@suse.com>
---
drivers/scsi/smartpqi/smartpqi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h
index b673825f46b5..9513357bd472 100644
--- a/drivers/scsi/smartpqi/smartpqi.h
+++ b/drivers/scsi/smartpqi/smartpqi.h
@@ -630,7 +630,7 @@ struct pqi_encryption_info {
};
#define PQI_MAX_OUTSTANDING_REQUESTS ((u32)~0)
-#define PQI_MAX_TRANSFER_SIZE (4 * 1024U * 1024U)
+#define PQI_MAX_TRANSFER_SIZE (1024U * 1024U)
#define RAID_MAP_MAX_ENTRIES 1024
--
2.12.3
next prev parent reply other threads:[~2017-06-23 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 9:40 [PATCH v2 1/2] hpsa: " Yadan Fan
2017-06-23 9:40 ` Yadan Fan [this message]
2017-06-23 13:01 ` [PATCH v2 2/2] smartpqi: " Johannes Thumshirn
2017-07-12 21:27 ` Martin K. Petersen
2017-06-23 13:01 ` [PATCH v2 1/2] hpsa: " Johannes Thumshirn
2017-06-26 17:35 ` Martin K. Petersen
2017-07-18 2:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623094006.16807-2-ydfan@suse.com \
--to=ydfan@suse.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®