From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbdFWOqf (ORCPT ); Fri, 23 Jun 2017 10:46:35 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:47179 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbdFWOqd (ORCPT ); Fri, 23 Jun 2017 10:46:33 -0400 Date: Fri, 23 Jun 2017 16:46:22 +0200 From: Maxime Ripard To: Ziping Chen Cc: Chen-Yu Tsai , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/3] input: sun4i-a10-lradc-keys: Add support for A83T Message-ID: <20170623144622.zn6ecwl2dwkc63w2@flea.lan> References: <20170620134445.23097-1-techping.chan@gmail.com> <20170620134445.23097-2-techping.chan@gmail.com> <20170621203502.ng7auh6vfmibobwo@flea.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pp7fmtkqt3q37zdb" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pp7fmtkqt3q37zdb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 22, 2017 at 12:50:47PM +0800, Ziping Chen wrote: > 2017-06-22 4:35 GMT+08:00 Maxime Ripard : >=20 > > On Tue, Jun 20, 2017 at 09:44:43PM +0800, Ziping Chen wrote: > > > From: Ziping Chen > > > > > > Allwinner A83T SoC has a low res adc like the one > > > in Allwinner A10 SoC, however, the A10 SoC's vref > > > of lradc internally is divided by 2/3 and the A83T > > > SoC's isn't, thus add a hardware variant for it to > > > be compatible with various devices. > > > > Where did you get that info from? > > > > Judging from the user manual, the threshold is actually set to 3/4, > > and not 2/3, but there's still one. > > >=20 > In the top of page 266 of the A10 User Manual V1.50, it said "2/3 ADC_REF > (Level A)" which mean Level A is 2/3 of the vref. >=20 > In the bottom of page 230 of the A83T User Manual V1.5.1, it said "1.35V > (Level A)" meaning that Level A is 1.35V. Oh, it's my fault... It's 3/4 of > the vref (A83T's ADC_REF is fixed at 1.8V). >=20 > So... i will change r_lradc_variant_a83t.divisor_numerator to 3 > and r_lradc_variant_a83t.divisor_denominator to 4... >=20 > Is there any other problems? I don't see any :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --pp7fmtkqt3q37zdb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZTSm+AAoJEBx+YmzsjxAgDuUQALOY3hY9UJUvn5cojLKC8Nhs W/5AIiWTi5n6rxo0b1io7UGY3bZ4p2TlQuzMejVJRw8adP0ujPT7UABUCRY6iK1T LlVxG82bM+OWSCvTtxO3JhejilB7dfpUjR42Y4imZHb7LxjIpHEbj96qJ07tMxte BeE8NVfTUU8MudXArtPz1mKq42gLRFK2n7BpJpkH2ezRcegORoc/LQ8b8/8dw5hN 2Qrgk0t5brvR1sfw1PQF/evdm9rgtqupnT0qCGhw++XeI+RFt/f8NPQf4KfMu5vl GA5T9EimTBxSLuORHMl2rU4f6gSpoVl3gHv1P8Dm1gZ6j3RkrF/Vd+y300q1Fy3H RQPzFxx/k+ST0sBAvP4s/LHeI361CTsEVdbyMs1paz7GU39n4zKwV/V/9ygQGK7X Hy5FzPwkEEQN4s1RCMac9uM9oP/nYD6GkHW5hSIsEyrWvVcI1nT/mrV5vqe+61Mv SpxnFiTwP0nIlvwpfv3CKZABNn646BeDPIu3nzbbBbdFTnh15OIbSv2RJKryZ6R7 ihNlpwlu+RVgdB6bbJ8WwLB9cz0c+ZNebG+c11fCkXSI9hvwOZ0pqP/TvTiz24ZS 8MYGpHG5fGDhKg6k4EDgfG2wOg/IUKqlillfdGTh78icwbND8cKqSagSJjCXAxxJ CzpuzAUN+1sWm1hQeVOA =0CO5 -----END PGP SIGNATURE----- --pp7fmtkqt3q37zdb--